flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maurice Amsellem (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-33970) Improve DropDownList skin implementation (mobile)
Date Sat, 14 Dec 2013 19:40:07 GMT

    [ https://issues.apache.org/jira/browse/FLEX-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848434#comment-13848434
] 

Maurice Amsellem commented on FLEX-33970:
-----------------------------------------

I appreciate that you took the time to design the skin in AS3, however:

1) DropDownListSkin should not contains any logic / behavioral code.  This is true for both
AS3 and mxml skins.
  - dropDown.open / dropDown.close should be in the hostComponent, not the skin
 - same for resize add/remove listener
 -  same for labelDisplay listener
 
2) labelDisplay is not needed.  you can use the button label instead, which does exactly the
same.

3) List should only have vertical scrolling, and no horizontal scrolling.  this is disturbing
when you swipe through the list

4) the screen-centered List popup makes only sense on phone devices.  
On tablets, the drop down list should be displayed close to the button, where space is available
(cf. CalloutButton placement rules).

5) and the skin by itself should be more elaborate (drop shadow, etc...)

That could sound like a lot of remarks, but writing Flex components, especially on mobile,
is not an easy task.
Keep the faith :-)

> Improve DropDownList skin implementation (mobile)
> -------------------------------------------------
>
>                 Key: FLEX-33970
>                 URL: https://issues.apache.org/jira/browse/FLEX-33970
>             Project: Apache Flex
>          Issue Type: Improvement
>          Components: Spark: DropDownList
>    Affects Versions: Apache Flex 4.8 (parity release)
>            Reporter: Lee Burrows
>            Priority: Minor
>             Fix For: Apache Flex 4.12.0
>
>         Attachments: DropDownList Skin Test.fxp
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Mobile theme does not contain skins for DropDownList.
> Spark theme skins are designed for 72dpi screens and are unsuitable for mobile devices.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message