flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maurice Amsellem (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (FLEX-33948) Add touch behaviour to spark DropDownList classes
Date Wed, 04 Dec 2013 22:51:35 GMT

    [ https://issues.apache.org/jira/browse/FLEX-33948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13839432#comment-13839432
] 

Maurice Amsellem edited comment on FLEX-33948 at 12/4/13 10:49 PM:
-------------------------------------------------------------------

Hi Lee, and thanks for patch #3.
Few remarks:
Coding:
* it's better to override your style-related code in styleChanged rather than styleInitialized
(if the styles are dynamically changed, the first one  will be called, but not the second
one).  See reference implementation in eg. mx.controls.Panel or spark SkinnableComponent
* You might want to cache the result of getStyle("interactionMode") != InteractionMode.TOUCH

Behavior:
* The DDL stills auto-close when I rotate the iPad
* the DDL sometimes closes unexpectedly, when you scroll the items.

To reproduce:
* DLL with 15 items, and large font on iPad 2
{code}
    <s:DropDownList id="ddl" dataProvider="{list15Items}" width="300"  fontSize="36"/>
{code} 
* select the first item, and close
* click on the button to pull down the menu
* scroll keeping your finger on the screen, slow down, then release => closes 

[edit] the issue unexpected close is not necessarily in your code.
It may be the touch scrolling that does not detect this kind of gesture, and mistakenly considers
it's a selection.


was (Author: mamsellem):
Hi Lee, and thanks for patch #3.
Few remarks:
Coding:
* it's better to override your style-related code in styleChanged rather than styleInitialized
(if the styles are dynamically changed, the first one  will be called, but not the second
one).  See reference implementation in eg. mx.controls.Panel or spark SkinnableComponent
* You might want to cache the result of getStyle("interactionMode") != InteractionMode.TOUCH

Behavior:
* The DDL stills auto-close when I rotate the iPad
* the DDL sometimes closes unexpectedly, when you scroll the items.

To reproduce:
* DLL with 15 items, and large font on iPad 2
{code}
    <s:DropDownList id="ddl" dataProvider="{list15Items}" width="300"  fontSize="36"/>
{code} 
* select the first item, and close
* click on the button to pull down the menu
* scroll keeping your finger on the screen, slow down, then release => closes 



> Add touch behaviour to spark DropDownList classes
> -------------------------------------------------
>
>                 Key: FLEX-33948
>                 URL: https://issues.apache.org/jira/browse/FLEX-33948
>             Project: Apache Flex
>          Issue Type: Improvement
>          Components: Spark: ComboBox, Spark: DropDownList
>    Affects Versions: Apache Flex 4.8 (parity release)
>            Reporter: Lee Burrows
>            Priority: Minor
>              Labels: features
>             Fix For: Apache Flex 4.12.0
>
>         Attachments: DropdownList Mobile Test v2.fxp, Fix_for_FLEX-33948_version_3.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Current spark DropDownList and ComboBox components do not work on touch devices. Attempting
to select an option closes the drop down without a selection being made.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message