Mailing-List: contact issues-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flex.apache.org
Date: Tue, 12 Nov 2013 11:03:24 +0000 (UTC)
From: "Benoit Wiart (JIRA)" <jira@apache.org>
To: issues@flex.apache.org
Message-ID: <JIRA.12678771.1384253857114.57179.1384254204271@arcas>
In-Reply-To: <JIRA.12678771.1384253857114@arcas>
References: <JIRA.12678771.1384253857114@arcas>
Subject: [jira] [Updated] (FLEX-33897) MediaQueryParser should not allocate
 memory for expressions already cached
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/FLEX-33897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benoit Wiart updated FLEX-33897:
--------------------------------

    Attachment: mediaquery-example-1.png

> MediaQueryParser should not allocate memory for expressions already cached
> --------------------------------------------------------------------------
>
>                 Key: FLEX-33897
>                 URL: https://issues.apache.org/jira/browse/FLEX-33897
>             Project: Apache Flex
>          Issue Type: Improvement
>          Components: Mobile: Performance, Styles
>    Affects Versions: Apache Flex 4.11.0
>         Environment: desktop mobile
>            Reporter: Benoit Wiart
>            Priority: Minor
>              Labels: memory, performance
>         Attachments: mediaquery-example-1.png
>
>
> When using @media from default sdk styles or custom styles
> the mxml compiler generates code like :
> if (styleManager.acceptMediaList("(application-dpi:160)"))
> {
>     this.focusThickness = 3;
>     this.fontSize = 24;
> }
> if (styleManager.acceptMediaList("(application-dpi:320)"))
> {
>     this.fontSize = 24;
> }
> if (styleManager.acceptMediaList("(application-dpi:480)"))
> {
>     this.focusThickness = 3;
>     this.fontSize = 24;
> }
> ...
> The acceptMediaList is often called, it delegates to MediaQueryParser which has a cache of known media expressions.
> But MediaQueryParser#parse allocates some memory even if the expression is in the cache. these allocations come from the string manipulation.
> this patch use the original expression as the key in the cache instead of the 'lowercased' expression.
> It will increase the cache size (by a small percentage) only if you have the same media expression in different case.


--
This message was sent by Atlassian JIRA
(v6.1#6144)