flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Danko Kozar (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (FLEX-33889) CSSStyleDeclaration->createProtoChainRoot() is obsolete
Date Mon, 11 Nov 2013 01:39:17 GMT

    [ https://issues.apache.org/jira/browse/FLEX-33889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818648#comment-13818648
] 

Danko Kozar edited comment on FLEX-33889 at 11/11/13 1:37 AM:
--------------------------------------------------------------

Even a greater chance than nobody except the original Style subsystem authors never used internal
methods such as this one ;)

This method has not been mentioned online since 2006 - and back then it was being "mentioned"
only in code repos like this one: http://www.cs.vu.nl/~eliens/assets/sdk/flex2/frameworks/source/mx/styles/CSSStyleDeclaration.as

However, you can leave it as it is - it can do no harm (adds only a few hundred bytes more
to Flex). 

Let's leave it for someone in 5 years from now to remove it ;)


was (Author: dkozar):
Even a greater chance than nobody except the original Style subsystem authors haven't been
using internal methods such as this one ;)

This method has not been mentioned online since 2006 - and back then it was being "mentioned"
only in code repos like this one: http://www.cs.vu.nl/~eliens/assets/sdk/flex2/frameworks/source/mx/styles/CSSStyleDeclaration.as

However, you can leave it as it is - it can do no harm (adds only a few hundred bytes more
to Flex). 

Let's leave it for someone in 5 years from now to remove it ;)

> CSSStyleDeclaration->createProtoChainRoot() is obsolete
> -------------------------------------------------------
>
>                 Key: FLEX-33889
>                 URL: https://issues.apache.org/jira/browse/FLEX-33889
>             Project: Apache Flex
>          Issue Type: Improvement
>          Components: Styles
>    Affects Versions: Apache Flex 4.11.0
>            Reporter: Danko Kozar
>            Priority: Trivial
>              Labels: CSSStyleDeclaration, StyleManager, css, quickfix, style,, stylesheet,,
styling,
>   Original Estimate: 2m
>  Remaining Estimate: 2m
>
> CSSStyleDeclaration->createProtoChainRoot() is obsolete (it seems since Macromedia
days). :)
> This is an "mx_internal" method, and couldn't find any references by the framework itself.
Am I right?
> Another method is used (for initializing the styles root) instead: SystemManagerImpl->initProtoChainRoots()
> Here's the actual method to remove:
> /**
>  *  @private
>  */
> mx_internal function createProtoChainRoot():Object
> {
> 	var root:Object = {};
> 	// If there's a defaultFactory for this style sheet,
> 	// then add the object it produces to the root.
> 	if (defaultFactory != null)
> 	{
> 		defaultFactory.prototype = root;
> 		root = new defaultFactory();
> 	}
> 	// If there's a factory for this style sheet,
> 	// then add the object it produces to the root.
> 	if (factory != null)
> 	{
> 		factory.prototype = root;
> 		root = new factory();
> 	}
> 	clones[ root ] = 1;
> 	
> 	return root;
> }



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message