flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maurice Amsellem (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-33875) Runtime error #1069 in MobileSkin class on focus out
Date Tue, 05 Nov 2013 11:02:18 GMT

    [ https://issues.apache.org/jira/browse/FLEX-33875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813844#comment-13813844
] 

Maurice Amsellem commented on FLEX-33875:
-----------------------------------------

As you said, it's not in the base class to provide strong typing.  
But it must be declared in every subclass.
I can't imagine how a skin class that does not somehow reference it's hostComponent could
do something useful.
So maybe we should check for hostComponent presence when the skin is attached, to ensure proper
implementation of the skin contract.
But that's another story...

> Runtime error #1069 in MobileSkin class on focus out
> ----------------------------------------------------
>
>                 Key: FLEX-33875
>                 URL: https://issues.apache.org/jira/browse/FLEX-33875
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: Skinning
>    Affects Versions: Apache Flex 4.10.0, Apache Flex 4.11.0
>            Reporter: Aleksey
>            Assignee: Justin Mclean
>              Labels: easyfix
>             Fix For: Apache Flex 4.12.0
>
>
> Hiting tab to move focus away from component which has pure AS skin without hostComponent
property defined results in runtime error. 
> Error happens in the endHighlightBitmapCapture of MobileSkin:
>     public function endHighlightBitmapCapture():Boolean
>     {
>         var exclusions:Array = focusSkinExclusions;
>         if (!exclusions)
>         {
>             if (this["hostComponent"] is SkinnableComponent)
>                 exclusions = SkinnableComponent(this["hostComponent"]).suggestedFocusSkinExclusions;
>         }
> Note that property accessed as dynamic property but there is no check for property existence.
It should be there just like in case of beginHighlightBitmapCapture:
>     public function beginHighlightBitmapCapture():Boolean
>     {
>         var exclusions:Array = focusSkinExclusions;
>         if (!exclusions)
>         {
>             if (("hostComponent" in this) && this["hostComponent"] is SkinnableComponent)
>                 exclusions = SkinnableComponent(this["hostComponent"]).suggestedFocusSkinExclusions;
>         }



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message