Mailing-List: contact issues-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flex.apache.org
Date: Fri, 4 Oct 2013 18:48:44 +0000 (UTC)
From: "Alex Harui (JIRA)" <jira@apache.org>
To: issues@flex.apache.org
Message-ID: <JIRA.12670021.1379933248998.15923.1380912524219@arcas>
In-Reply-To: <JIRA.12670021.1379933248998@arcas>
References: <JIRA.12670021.1379933248998@arcas>
Subject: [jira] [Commented] (FLEX-33772) Incorrect tab focus behavior
 (closed loops) when using focus groups (such as RadioButton components)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/FLEX-33772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786488#comment-13786488 ] 

Alex Harui commented on FLEX-33772:
-----------------------------------

Ok, took a look at the new patch. Looks pretty good, thanks for figuring it out.  I think I see your strategy, and I'm ok with it.

There is one behavioral change:  For 3 contiguous radiobuttons of which none are selected, If you shift-tab onto the 3rd one, the first one now gets selected.  In the old behavior the 3rd one gets selected.

I want to know more about the test cases in your comment on 9/23 where you say there is a "known limitation".  This makes it sound like there some other behavioral change or bug.  What is the scenario that exposes this limitation?  We don't want to break existing apps just to fix this bug.

Finally, it looks like you are adding another potentially full loop through all of the focusableCandidates.  There is a call to isEnabledAndVisible in the loop which does a parent walk up the display list.  Most folks probably won't feel it, but there could be extreme cases where folks would feel it.  That's why I suggested detecting that there were non-contiguous radiobuttons and this loop is needed, so everyone wouldn't be prone to any potential performance issues from this loop.


> Incorrect tab focus behavior (closed loops) when using focus groups (such as RadioButton components)
> ----------------------------------------------------------------------------------------------------
>
>                 Key: FLEX-33772
>                 URL: https://issues.apache.org/jira/browse/FLEX-33772
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: Focus Manager
>    Affects Versions: Apache Flex 4.11.0
>            Reporter: Cosma Colanicchia
>            Assignee: Alex Harui
>            Priority: Minor
>              Labels: patch
>         Attachments: FocusManager.patch, FocusManager.patch, TestFocus-current.air, TestFocus.mxml, TestFocus-patched.air, TestFocus-screenshot.png, TestFocus-updated.mxml
>
>
> When additional components that are not part of the focus group are positioned between two group elements, it may be impossible to move the focus away from the group using the keyboard.


--
This message was sent by Atlassian JIRA
(v6.1#6144)