flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Justin Mclean (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-33683) Bad ordering of ListCollectionView addAllAt
Date Fri, 13 Sep 2013 00:00:51 GMT

    [ https://issues.apache.org/jira/browse/FLEX-33683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766042#comment-13766042
] 

Justin Mclean commented on FLEX-33683:
--------------------------------------

Checked into develop branch, all collection test pass, however addAllAt isn't actually used
anywhere in the SDK code.
                
> Bad ordering of ListCollectionView addAllAt
> -------------------------------------------
>
>                 Key: FLEX-33683
>                 URL: https://issues.apache.org/jira/browse/FLEX-33683
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: Collections
>    Affects Versions: Apache Flex 4.10.0
>         Environment: Flex 4.10 (compiled for AIR 3.4, Flash Player 11.4
>            Reporter: Marcus Wilkinson
>             Fix For: Apache Flex 4.11.0
>
>         Attachments: AddAllOrder.mxml
>
>
> Steps to reproduce:
> 1) Create an ArrayCollection (collectionA) with N elements
> 2) Create a second ArrayCollection (collectionB) with less than N elements
> 3) Call collectionA.adAll(collectionB)
> Expected result:
> All elements of collectionB are added to the *end* of collectionA
> Actual Result
> All elements of collectionB are added to collectionA at position [collectionB.length]
> Suggested fix:
>  ListCollectionView.addAllAt : 664
> https://github.com/apache/flex-sdk/blob/develop/frameworks/projects/framework/src/mx/collections/ListCollectionView.as#L664
> Change
> 		var maxLength:int = length
> to
> 		var maxLength:int = this.length;

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message