flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Harui (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-33409) TLF crashes when hypens are shown in a multi span textFlow
Date Thu, 29 Aug 2013 06:21:54 GMT

    [ https://issues.apache.org/jira/browse/FLEX-33409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753363#comment-13753363
] 

Alex Harui commented on FLEX-33409:
-----------------------------------

The player has two bugs.  It cannot always re-compute the correct atom positions in TextBlock.findPreviousAtomBoundary.
 Especially when TextElement.replaceText modifies the text.  See the "when" scenario in the
comments.

The other is that it cannot compute TextLine.textBlockBeginIndex and TextLine.rawTextLength
consistently if you only generate TextLines starting from the middle of the TextBlock and
do not generate TextLines for all lines that are broken with hyphens.

I added code to ParagraphElement in the first case to compute the atom boundary from the TextLine,
but it may not be as fast as TextBlock.findPreviousAtomBoundary.

I added code TLF to always generate every TextLine if it broken on hyphens.  In the test case
where you backspace in the second container, TLF was only generating TextLines for the second
container.

This will be a performance drag, so I added a flag to ContainerController to use the old code
paths that don't support hyphens.

                
> TLF crashes when hypens are shown in a multi span textFlow
> ----------------------------------------------------------
>
>                 Key: FLEX-33409
>                 URL: https://issues.apache.org/jira/browse/FLEX-33409
>             Project: Apache Flex
>          Issue Type: Bug
>    Affects Versions: Adobe Flex SDK 4.6 (Release)
>         Environment: TLF editing
>            Reporter: Woodwing Developer
>            Assignee: Alex Harui
>            Priority: Blocker
>              Labels: TLF, crash, editing, hyphen, span, textflow
>         Attachments: BaseCompose.as, ComposeState.as, ContainerController.as, ExampleDebug.fxp,
FLEX33409.patch, FlowComposerBase.as, FlowLeafElement.as, ParagraphElement.as, Test.fxp, textLayout.swc
>
>
> When soft hyphens are used and shown, in a textFlow with 2 or more spans, TLF crashes
when typing.
> Import the underlying text flow xml. Resize the text area until the hyphen is visible.
Then start typing AFTER the hypened word, also pressing the enter key. TLF crashes.
> Sample textFLow (if the soft hyphen is not show, insert a new one in the appropriate
word):
>   <TextFlow color="#000000" fontSize="12" lineHeight="14" paddingBottom="0" paddingLeft="10"
paddingRight="10" paddingTop="0" whiteSpaceCollapse="preserve" version="2.0.0" xmlns="http://ns.adobe.com/textLayout/2008">
>     <p>
>       <span backgroundColor="#ffffff" textDecoration="underline">First Span</span>
>       <span backgroundColor="#ffffff" textDecoration="none"> Second span. This
text has a hypen in the next long word LongWord­WithAHyphen. Make sure the hypen is shown!
Then start typing and pressing enter till TLF crashes (should happen fast enough)</span>
>   </p>
>   </TextFlow>
> It seems that the textLine is damaged but the text engine fails to recompose the line
properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message