flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Piotr Zarzycki <piotrzarzyck...@gmail.com>
Subject Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*
Date Wed, 15 Nov 2017 08:04:22 GMT
Hi Alex,

I just tried JAVA_TOOL_OPTIONS and that was it! Thank you and I will cut
another RC very soon!

Piotr

2017-11-14 19:26 GMT+01:00 Alex Harui <aharui@adobe.com.invalid>:

> I couldn't see the screenshot, but I assume it didn't match.  The goal is
> to get it to match.  I still think the issue is the Ant Copy task.  Have
> you tried using the JAVA_TOOL_OPTIONS environment variable?  I know the CI
> server is using it.
>
>
>     -Dfile.encoding=UTF8
>
> Another option you have is to update the build.xml and set the
> outputencoding="utf-8" on all file tasks.  You will know you have it right
> when you can unpack the source package and the characters match up.  Until
> then, it isn't really worth putting out another RC.
>
> Good luck,
> -Alex
>
> From: Piotr Zarzycki <piotrzarzycki21@gmail.com<mailto:
> piotrzarzycki21@gmail.com>>
> Reply-To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" <
> dev@flex.apache.org<mailto:dev@flex.apache.org>>
> Date: Tuesday, November 14, 2017 at 10:06 AM
> To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" <dev@flex.apache.org
> <mailto:dev@flex.apache.org>>
> Subject: Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*
>
> Hi Alex,
>
> I'm running out of time for today, but I just look into the:
> frameworks/tests/basicTests/spark/views/SortTests.mxml in my local
> repository on Windows I see exactly same as you pasted here:
>
> "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]);
>
> But when I unpack on my Windows RC2 sources from zip I see in that file
> this one:
>
> [Obraz w treści 1]
>
> Can you see screenshot above ?
>
> Thanks, Piotr
>
>
> 2017-11-14 8:47 GMT+01:00 Alex Harui <aharui@adobe.com.invalid<mailto:
> aharui@adobe.com.invalid>>:
> Piotr,
>
> If you look at your repo's copy of
> frameworks/tests/basicTests/spark/views/SortTests.mxml, around line 43 you
> should see:
>
>       "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]);
>
> Note the character before "(U+5DDD)".  It should look like 1 curved line
> followed by 2 straight lines.
>
>
> In the RC1 source package, it looked like this (on Mac):
>
>       "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "?? (U+5DDD)"]);
>
> Note the "??" before "(U+5DDD)".  And it also wasn't right on Windows
> (en_US).
>
>
> I'm wondering, what do you see on your system?  And what do you see in
> RC2?  I haven't looked yet, and I'm pretty much out of time for tonight.
> It could be that on your Windows system, even for RC1 you will see the 1
> curved line followed by 2 straight lines.  But I'm pretty sure your Mac
> should have the "??" for RC1.  If RC2 has the 1 curved line followed by
> two 2 straight lines, then you probably got it right, but I'm more
> suspicious of the Ant file manipulation than I am of Git's manipulation of
> the files.
>
> If you don't touch line endings when you pull from Git, you still should
> ensure that the Windows .bat files have DOS line endings otherwise they
> become hard to read on Windows systems.  I'm not sure the build script is
> set up to do that.  It might assume that if you are on Windows, you don't
> need to touch the .bat files.
>
> HTH,
> -Alex
>
> On 11/13/17, 11:22 PM, "Piotr Zarzycki" <piotrzarzycki21@gmail.com<mailto:
> piotrzarzycki21@gmail.com>> wrote:
>
> >Alex,
> >
> >I understand what is all about with chmod as it was in FlexJS (not sure
> >which file should be converted), but I would like to leave it as is now.
> >Unfortunately I don't understand your last sentence:
> >
> >"I was hoping the source files would be valid on Windows, but I just
> >checked and even there they are not.  I'm guessing that Piotr's default
> >character encoding for Windows where he lives is different than US
> >Windows.  I'm not sure there is a workaround to convert those files back
> >to UTF8 or not.  But given they don't look right in US Windows systems,
> >unless there is an easy workaround, it might be a good idea to fix this
> >issue in another RC."
> >
> >I just pushed RC2, where I have checkouted once again whole repository
> >having all files unchanged in case of line endings. Now sh scripts are
> >runnable on Mac. I just run also installer.xml and it's working. I will
> >wait for Justin's look into the pushed RC2 before I officially cut it.
> >
> >Thanks, Piotr
> >
> >
> >2017-11-14 7:56 GMT+01:00 Alex Harui <aharui@adobe.com.invalid<mailto:
> aharui@adobe.com.invalid>>:
> >
> >>
> >>
> >> On 11/13/17, 6:27 PM, "Justin Mclean" <justinmclean@me.com<mailto:ju
> stinmclean@me.com>> wrote:
> >>
> >> >Hi,
> >> >
> >> >> Is the DateChooser problem from your local build of the sources or
> >>from
> >> >> the RC binary artifacts?
> >> >
> >> >A local built from the compiled source bundled I've not tested the
> >>binary
> >> >yet but given it was made from the source release I would expect it to
> >> >show the same issues. Or are you saying that the binary artefact was
> >>not
> >> >made from the code in the source release?
> >>
> >> The binaries are not created by first creating the source package,
> >> unpacking it and compiling it.  You were a Flex SDK RM at least once,
> >>did
> >> you not understand what you were signing?  The build builds the sources
> >>it
> >> got from the repo and assumes that the copy to the temp folder to create
> >> the source package will not modify the files, but it looks like at least
> >> on Windows, Ant will change the character encoding in the copy unless
> >>you
> >> use JAVA_TOOL_OPTIONS.  That is something we should figure out how to
> >> prevent in the future, either by documenting how to prevent character
> >> encoding changes or by changing the build script.  And in my tests, the
> >> binary artifact did work correctly.
> >> >
> >> >Either way it's the source that’s the offical release and it seems
> >> >unusual to release a broken source release even if the binary did work.
> >>
> >> I was hoping the source files would be valid on Windows, but I just
> >> checked and even there they are not.  I'm guessing that Piotr's default
> >> character encoding for Windows where he lives is different than US
> >> Windows.  I'm not sure there is a workaround to convert those files back
> >> to UTF8 or not.  But given they don't look right in US Windows systems,
> >> unless there is an easy workaround, it might be a good idea to fix this
> >> issue in another RC.
> >>
> >> -Alex
> >>
> >>
> >
> >
> >--
> >
> >Piotr Zarzycki
> >
> >Patreon:
> >*https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.patr
> >eon.com<https://na01.safelinks.protection.outlook.
> com/?url=http%3A%2F%2Feon.com&data=02%7C01%7C%
> 7Cbbfcf475660b4a5b666708d52b8a666e%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C636462795785096599&sdata=RXYk9VGEGZtdX8fa6CD0aGCy4NOAW9
> HCknpvEdrQvmw%3D&reserved=0>%2Fpiotrzarzycki&data=02%7C01%7C%
> 7C05fef9a080cd4c323c8b08d52b307cc5
> >%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C636462409610237907&sdata=Dy2
> >BgGtCgZ7r7k%2FricqDFyij5o9KzTSwURSD%2F1un64Q%3D&reserved=0
> ><https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.patr
> >eon.com<https://na01.safelinks.protection.outlook.
> com/?url=http%3A%2F%2Feon.com&data=02%7C01%7C%
> 7Cbbfcf475660b4a5b666708d52b8a666e%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C636462795785096599&sdata=RXYk9VGEGZtdX8fa6CD0aGCy4NOAW9
> HCknpvEdrQvmw%3D&reserved=0>%2Fpiotrzarzycki&data=02%7C01%7C%
> 7C05fef9a080cd4c323c8b08d52b307cc5
> >%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C636462409610237907&sdata=Dy2
> >BgGtCgZ7r7k%2FricqDFyij5o9KzTSwURSD%2F1un64Q%3D&reserved=0>*
>
>
>
>
> --
>
> Piotr Zarzycki
>
> Patreon: https://www.patreon.com/piotrzarzycki<https://na01.
> safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.
> patreon.com%2Fpiotrzarzycki&data=02%7C01%7C%7Cbbfcf475660b4a5b666708d52b8a
> 666e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C636462795785096599&sdata=jJosNusW2Z7AwP3frtCOmTqoKl5G42
> ON1ffOSBxO1zg%3D&reserved=0>
>



-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
<https://www.patreon.com/piotrzarzycki>*

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message