Mailing-List: contact dev-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flex.apache.org
MIME-Version: 1.0
In-Reply-To: <CANDXkxCTMujvHO=qDummTTYH_DFi04WZxQpbg2QjiqJ=fPzy4g@mail.gmail.com>
References: <54F78FFC-D59D-4E50-A7B7-1F3935022F20@gmail.com>
 <D5AD484F.9AAC0%aharui@adobe.com> <8C7468A6-C439-4F06-AA87-9989CDE32087@gmail.com>
 <D5AD5409.9AAE9%aharui@adobe.com> <7519704C-E6AF-4A03-B84F-E5EE05E6A3E7@gmail.com>
 <727AE3D9-59CC-4586-861A-86AC2F8A653A@gmail.com> <D5ADC9F5.9AB1D%aharui@adobe.com>
 <4D6CD13D-9996-4603-8C05-FD5A86C50A65@gmail.com> <D5ADD47F.9AB3B%aharui@adobe.com>
 <E895181D-06B2-4E53-A979-A23F1757A6D6@gmail.com> <D5ADDD3E.9AB5F%aharui@adobe.com>
 <D5AF7319.9ADA4%aharui@adobe.com> <CANDXkxCTMujvHO=qDummTTYH_DFi04WZxQpbg2QjiqJ=fPzy4g@mail.gmail.com>
From: Greg Dove <greg.dove@gmail.com>
Date: Wed, 9 Aug 2017 09:22:15 +1200
Message-ID: <CANDXkxBq8p2OOGABAGCFsoTbN9_HUu1oMPStamopSw2SZ_q-Qw@mail.gmail.com>
Subject: Re: Package, Class and Method renaming
To: dev@flex.apache.org
Content-Type: multipart/alternative; boundary="94eb2c195d28c013210556448ea9"
archived-at: Tue, 08 Aug 2017 21:22:27 -0000

--94eb2c195d28c013210556448ea9
Content-Type: text/plain; charset="UTF-8"

I guess that might help with the code minification, but it may be
irrelevant with the longer original strings with something like gzip
compression already.... there are so many levels to this.


On Wed, Aug 9, 2017 at 9:12 AM, Greg Dove <greg.dove@gmail.com> wrote:

> Alex fyi I have wondered about breaking the class strings into literal
> concatenation expressions with package parts for CLASS_INFO and in the
> reflection data. This should end up minifying via closure compiler much
> better, I think.
> e.g.
>
> 'org.'+'apache.'+'flex.'+'events.'+'Event'
>
>
>
>
> On Wed, Aug 9, 2017 at 9:01 AM, Alex Harui <aharui@adobe.com.invalid>
> wrote:
>
>> So I just pushed a first crack at suppressing most @export statements.
>> Set -export-public-symbols=false and many @export statements should go
>> away.  The before size of TLFEditTestFlexJS was 813493 bytes.  I
>> recompiled TLF without @export symbols and the after size was 679609
>> bytes.  And it ran.
>>
>> Some things I found were that MXML isn't a problem because the id maps to
>> a getter/setter which maps to Object.DefineProperty which takes an object
>> structure where the ids are keys so they don't get renamed.  I noticed
>> that class names take up a lot of strings because they are used as a
>> literal in the FLEXJS_CLASS_INFO and thus never get minified/renamed.
>>
>> Anyway, try compiling and running your application code with this option
>> set to false and see if it obfuscates things enough or not, and whether
>> the result still runs.
>>
>> Thanks,
>> -Alex
>>
>> On 8/7/17, 9:06 AM, "Alex Harui" <aharui@adobe.com.INVALID> wrote:
>>
>> >From the output side, it probably isn't hard, but there is no way
>> succinct
>> >way to tell the compiler which classes should use @export or not.  You
>> >could annotate the class definitions, but then you can't choose to output
>> >@export without changing source.
>> >
>> >Why do you think we need per-class control over this output?
>> >
>> >-Alex
>> >
>> >On 8/7/17, 8:54 AM, "Harbs" <harbs.lists@gmail.com> wrote:
>> >
>> >>Cool.
>> >>
>> >>How difficult would it be to allow this on a class-by-class basis?
>> >>
>> >>> On Aug 7, 2017, at 6:35 PM, Alex Harui <aharui@adobe.com.INVALID>
>> >>>wrote:
>> >>>
>> >>> First thing I will do, though, is allow turning off @export output on
>> >>> entire compiler sessions.  That might allow you to have your text
>> >>>engine
>> >>> and your application logic more aggressively renamed but not require
>> us
>> >>>to
>> >>> fix code in other SWCs that might use bracket access.
>> >>
>> >
>>
>>
>

--94eb2c195d28c013210556448ea9--