flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Piotr Zarzycki <piotrzarzyck...@gmail.com>
Subject Re: git commit: [flex-asjs] [refs/heads/develop] - Added helper function
Date Sun, 27 Aug 2017 09:55:01 GMT
Please create folder helper. I think we will have more classes with time. :)

2017-08-27 11:41 GMT+02:00 Harbs <harbs.lists@gmail.com>:

> I’ve already started using it for a number of classes. I did not yet
> commit those changes because the changed classes still need more work.
>
> I’m not sure accessories or supportClasses is the right place.
>
> Maybe we should add a “helper” folder for function files.
>
> Harbs
>
> > On Aug 27, 2017, at 12:25 PM, Piotr Zarzycki <piotrzarzycki21@gmail.com>
> wrote:
> >
> > Hi Harbs,
> >
> > Thanks for adding it - That may be really helpful.
> > I think you should consider move it to one of the folder to Basic:
> > accessories or supportClasses.
> >
> > If you could also add version when it was introduced etc.
> >
> > What do you think?
> >
> > Thanks,
> > Piotr
> >
> > On Sun, Aug 27, 2017, 06:43 <harbs@apache.org> wrote:
> >
> >> Repository: flex-asjs
> >> Updated Branches:
> >>  refs/heads/develop 5b8f1c589 -> daca90f9e
> >>
> >>
> >> Added helper function
> >>
> >>
> >> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> >> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/daca
> 90f9
> >> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/daca90f9
> >> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/daca90f9
> >>
> >> Branch: refs/heads/develop
> >> Commit: daca90f9e688a3ac79edd569f759df2b5ba89b80
> >> Parents: 5b8f1c5
> >> Author: Harbs <harbs@in-tools.com>
> >> Authored: Sun Aug 27 07:43:25 2017 +0300
> >> Committer: Harbs <harbs@in-tools.com>
> >> Committed: Sun Aug 27 07:43:25 2017 +0300
> >>
> >> ----------------------------------------------------------------------
> >> .../Basic/src/main/flex/BasicClasses.as         |  4 ++++
> >> .../org/apache/flex/html/addElementToWrapper.as | 20
> ++++++++++++++++++++
> >> 2 files changed, 24 insertions(+)
> >> ----------------------------------------------------------------------
> >>
> >>
> >>
> >> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/daca90
> f9/frameworks/projects/Basic/src/main/flex/BasicClasses.as
> >> ----------------------------------------------------------------------
> >> diff --git a/frameworks/projects/Basic/src/main/flex/BasicClasses.as
> >> b/frameworks/projects/Basic/src/main/flex/BasicClasses.as
> >> index 697efa8..bc62158 100644
> >> --- a/frameworks/projects/Basic/src/main/flex/BasicClasses.as
> >> +++ b/frameworks/projects/Basic/src/main/flex/BasicClasses.as
> >> @@ -27,6 +27,10 @@ package
> >>  */
> >> internal class BasicClasses
> >> {
> >> +       COMPILE::JS
> >> +       {
> >> +               import org.apache.flex.html.addElementToWrapper;
> >> addElementToWrapper;
> >> +       }
> >>     import org.apache.flex.html.ToolTip; ToolTip;
> >>        import org.apache.flex.html.accessori
> es.NumericOnlyTextInputBead;
> >> NumericOnlyTextInputBead;
> >>     import org.apache.flex.html.beads.DispatchInputFinishedBead;
> >> DispatchInputFinishedBead;
> >>
> >>
> >> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/daca90
> f9/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> html/addElementToWrapper.as
> >> ----------------------------------------------------------------------
> >> diff --git
> >> a/frameworks/projects/Basic/src/main/flex/org/apache/flex/ht
> ml/addElementToWrapper.as
> >> b/frameworks/projects/Basic/src/main/flex/org/apache/flex/ht
> ml/addElementToWrapper.as
> >> new file mode 100644
> >> index 0000000..0c4427c
> >> --- /dev/null
> >> +++
> >> b/frameworks/projects/Basic/src/main/flex/org/apache/flex/ht
> ml/addElementToWrapper.as
> >> @@ -0,0 +1,20 @@
> >> +package org.apache.flex.html
> >> +{
> >> +    COMPILE::JS
> >> +    {
> >> +        import org.apache.flex.core.UIBase;
> >> +        import org.apache.flex.core.WrappedHTMLElement;
> >> +    }
> >> +
> >> +    /**
> >> +     * @flexjsignorecoercion org.apache.flex.core.WrappedHTMLElement
> >> +     */
> >> +    COMPILE::JS
> >> +    public function
> >> addElementToWrapper(wrapper:UIBase,type:String):WrappedHTMLElement
> >> +    {
> >> +        var elem:WrappedHTMLElement = document.createElement(type) as
> >> WrappedHTMLElement;
> >> +                       wrapper.positioner = wrapper.element = elem;
> >> +                       elem.flexjs_wrapper = wrapper;
> >> +            return elem;
> >> +    }
> >> +}
> >> \ No newline at end of file
> >>
> >>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message