Mailing-List: contact dev-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flex.apache.org
MIME-Version: 1.0
In-Reply-To: <D5937545.9972F%aharui@adobe.com>
References: <9F4DC2C2-E17F-4E8B-BBDB-549D68CD0363@comcast.net>
 <FE87D441-EA82-4EC7-9817-AFB4F3801BD0@classsoftware.com> <2EC06E15-0D0D-4AAF-867A-00A7A81E2D2F@comcast.net>
 <B467F829-2810-439D-91E3-6A4164F1DB1F@classsoftware.com> <230AA013-ABEA-41BE-BA8C-4A8D100B07D2@gmail.com>
 <283F5BD1-09F7-491B-9386-64D7070106F7@classsoftware.com> <1499588291853-62975.post@n4.nabble.com>
 <F28907F1-4448-412C-BAC2-9245AA6ED4C2@classsoftware.com> <1499597249842-62980.post@n4.nabble.com>
 <B945FA65-71AB-4EB0-8594-5D7C92DBB521@classsoftware.com> <1499668086643-63016.post@n4.nabble.com>
 <FE443C4B-ACF7-41DE-B648-2E2C6884841F@gmail.com> <31661087-AAC8-4432-BAD5-0913E4EEFF18@classsoftware.com>
 <4BE221F8-26A7-4160-A910-59D8D489B2AF@gmail.com> <DB2D59C4-7473-4722-830E-39A6A12D7D4C@classsoftware.com>
 <EAFC156C-DE37-473A-90C5-47D3E260331A@gmail.com> <1F415DBB-DBD3-4A10-8405-2B12CB50C5A5@classsoftware.com>
 <9BE33294-A89B-423F-A1CA-0DE037D32D51@gmail.com> <D5937545.9972F%aharui@adobe.com>
From: Josh Tynjala <joshtynjala@gmail.com>
Date: Tue, 18 Jul 2017 08:35:34 -0700
Message-ID: <CADZSWG5Zxsq6KVAtJrf8Re42=oD73vYaA9seOxu7hJdZfctwhw@mail.gmail.com>
Subject: Re: [FlexJS] technical debt
To: dev@flex.apache.org
Content-Type: multipart/alternative; boundary="001a1144ce4aa88fc6055499469d"
archived-at: Tue, 18 Jul 2017 15:36:22 -0000

--001a1144ce4aa88fc6055499469d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Additionally, the cloning results in extra objects that need to be garbage
collected, which can hurt performance and make effects/animations look bad.
Good call on avoiding it!

- Josh

On Tue, Jul 18, 2017 at 8:23 AM, Alex Harui <aharui@adobe.com.invalid>
wrote:

> +1 to what Harbs said.
>
> Also, in FlexJS, we want very few if any custom events to bubble.
> Bubbling was overused in regular Flex and was, IMO, a bad practice becaus=
e
> it breaks encapsulation.
>
> Bubbling was intended to allow an object in the DOM to monitor inputs to
> its children without having to attach listeners to the entire tree.  It
> was not meant as a way for a component to shout to the world "Hey, I just
> changed a property, does anybody care?"
>
> -Alex
>
> On 7/17/17, 11:05 PM, "Harbs" <harbs.lists@gmail.com> wrote:
>
> >event.clone() is wrong for FlexJS. It=E2=80=99s event.cloneEvent()
> >
> >There was other feedback on the dev list. That seemed to have been
> >ignored.
> >
> >A lot of the rules fly in the face to current convention in the SDK. Som=
e
> >(such as returning from a constructor) are actually enforced by the
> >compiler so the rule is not needed. I don=E2=80=99t have time right now =
to get
> >involved in a long protracted discussion, but please don=E2=80=99t take =
the lack
> >of input as consensus.
> >
> >Feel free to do what you want to SonarQube now, but don=E2=80=99t make a=
ny
> >changes based on the reports. If anyone else takes an interest in it,
> >please expect some rules to be changed.
> >
> >Thanks,
> >Harbs
> >
> >> On Jul 18, 2017, at 8:50 AM, Justin Mclean <justin@classsoftware.com>
> >>wrote:
> >>
> >> Hi,
> >>
> >> So more than a week has gone by and I=E2=80=99ve received little feedb=
ack on
> >>[1]. Given that I=E2=80=99ll gone ahead and implement the rules as disc=
ussed in
> >>the document so people can see the changes.
> >>
> >> The new results are up:
> >> - First off the header rules is overly strict and expects a copyright
> >>line not just a header. ASF policy to not to have copyright lines so
> >>this is a false positive. I=E2=80=99ll disable the rule. We have other =
means to
> >>check headers. This will be fixed in the next run.
> >> - The ASDocs rule is picking a lot of public methods and properties
> >>that don=E2=80=99t have ASDocs. I think we should keep this to remind u=
s at some
> >>point it needs to be fixed / people can fix as they make edits.
> >> - Is easier to see if issues that do need to be fixed. For instance I
> >>can see that there are a couple of event.clone issues that are likely
> >>bugs.
> >>
> >> Thanks,
> >> Justin
> >>
> >> 1.
> >>https://na01.safelinks.protection.outlook.com/?url=3D
> https%3A%2F%2Fcwiki.ap
> >>ache.org%2Fconfluence%2Fdisplay%2FFLEX%2FSonar%
> 2BCube%2BFlex%2BRules&data
> >>=3D02%7C01%7C%7C9be74a7882374975005208d4cda30749%
> 7Cfa7b1b5a7b34438794aed2c1
> >>78decee1%7C0%7C0%7C636359547464506542&sdata=3D
> cPs4sqimu5YFG%2B08ymZNtb9HMWC
> >>WFGixhtyGrP0burM%3D&reserved=3D0
> >><https://na01.safelinks.protection.outlook.com/?url=3D
> https%3A%2F%2Fcwiki.a
> >>pache.org%2Fconfluence%2Fdisplay%2FFLEX%2FSonar%
> 2BCube%2BFlex%2BRules&dat
> >>a=3D02%7C01%7C%7C9be74a7882374975005208d4cda3
> 0749%7Cfa7b1b5a7b34438794aed2c
> >>178decee1%7C0%7C0%7C636359547464506542&sdata=3D
> cPs4sqimu5YFG%2B08ymZNtb9HMW
> >>CWFGixhtyGrP0burM%3D&reserved=3D0>
> >
>
>

--001a1144ce4aa88fc6055499469d--