Mailing-List: contact dev-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flex.apache.org
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
Subject: Re: git commit: [flex-asjs] [refs/heads/develop] - This appears to be inoperative. I believe this change is correct, but it really needs a test.
From: Harbs <harbs.lists@gmail.com>
In-Reply-To: <51d34a6dc51048018d0a5a0d76262ab3@git.apache.org>
Date: Mon, 24 Jul 2017 13:32:15 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <A9E9E82A-8107-4F8A-9BB4-277D82228C29@gmail.com>
References: <51d34a6dc51048018d0a5a0d76262ab3@git.apache.org>
To: dev@flex.apache.org
archived-at: Mon, 24 Jul 2017 10:32:29 -0000

While researching the issue I had, I noticed this code.

It appears to be removing the event handlers from the object and then =
adding them back to the same objects. I believe the change I wrote is =
necessary to add the event handlers to the new object, but I=E2=80=99d =
appreciate if we get some additional eyeballs on this.

I did not see any tests for this, and I don=E2=80=99t have the time =
right now to write one.

Thanks,
Harbs
=20
> On Jul 24, 2017, at 1:29 PM, harbs@apache.org wrote:
>=20
> Repository: flex-asjs
> Updated Branches:
>  refs/heads/develop 2458fe559 -> 61ef18b9a
>=20
>=20
> This appears to be inoperative. I believe this change is correct, but =
it really needs a test.
>=20
>=20
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: =
http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/61ef18b9
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/61ef18b9
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/61ef18b9
>=20
> Branch: refs/heads/develop
> Commit: 61ef18b9adce1b6fbc650cd07654198e90d780d5
> Parents: 2458fe5
> Author: Harbs <harbs@in-tools.com>
> Authored: Mon Jul 24 13:29:05 2017 +0300
> Committer: Harbs <harbs@in-tools.com>
> Committed: Mon Jul 24 13:29:05 2017 +0300
>=20
> ----------------------------------------------------------------------
> .../flex/org/apache/flex/html/beads/DataProviderChangeNotifier.as | 3 =
+++
> 1 file changed, 3 insertions(+)
> ----------------------------------------------------------------------
>=20
>=20
> =
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/61ef18b9/frameworks/=
projects/Basic/src/main/flex/org/apache/flex/html/beads/DataProviderChange=
Notifier.as
> ----------------------------------------------------------------------
> diff --git =
a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/DataP=
roviderChangeNotifier.as =
b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/DataP=
roviderChangeNotifier.as
> index e8c28bd..bab1c4a 100644
> --- =
a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/DataP=
roviderChangeNotifier.as
> +++ =
b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/DataP=
roviderChangeNotifier.as
> @@ -56,10 +56,13 @@ package org.apache.flex.html.beads
> 			}
> 			else
> 			{
> +				if(object[propertyName] =3D=3D =
dataProvider)
> +					return;
>                 dataProvider.removeEventListener("itemAdded", =
handleDataProviderChanges);
>                 dataProvider.removeEventListener("itemRemoved", =
handleDataProviderChanges);
>                 dataProvider.removeEventListener("itemUpdated", =
handleDataProviderChanges);
>                 dataProvider.removeEventListener("collectionChanged", =
handleDataProviderChanges);
> +				dataProvider =3D object[propertyName] as =
ArrayList;
> 			}
>=20
>             dataProvider.addEventListener("itemAdded", =
handleDataProviderChanges);
>=20