Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F37B6200CC8 for ; Fri, 14 Jul 2017 17:34:18 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id F1F5616DE9D; Fri, 14 Jul 2017 15:34:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1C2BF16DE98 for ; Fri, 14 Jul 2017 17:34:17 +0200 (CEST) Received: (qmail 8656 invoked by uid 500); 14 Jul 2017 15:34:12 -0000 Mailing-List: contact dev-help@flex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flex.apache.org Delivered-To: mailing list dev@flex.apache.org Received: (qmail 8644 invoked by uid 99); 14 Jul 2017 15:34:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Jul 2017 15:34:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 891181A0135 for ; Fri, 14 Jul 2017 15:34:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.121 X-Spam-Level: X-Spam-Status: No, score=-0.121 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 8aaK1jIeT3yj for ; Fri, 14 Jul 2017 15:34:10 +0000 (UTC) Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id BC2635FD38 for ; Fri, 14 Jul 2017 15:34:09 +0000 (UTC) Received: by mail-wm0-f48.google.com with SMTP id 62so23755741wmw.1 for ; Fri, 14 Jul 2017 08:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date :content-transfer-encoding:message-id:references:to; bh=yQskH8B9urJ9OkrCtjdI7iZAb6qTqmaqiI6B4IC99TA=; b=L/aHUeGHbmJsJTyBtThcVaHRGsSZ+WU/sijz3fSFiCnNJWvTc3ACXMF5QOOqXNbOBI 9anV6RGkrV0E+3oad/vYNEtEFohobSTGVtdhOS7o5gAkWxj7QhuZ3jEchjhq9Y1aXFLp DJ8Bpmm3oC9u92RHTsZVPTHSQpSq+3ZC9lpSGAjvMMPFLuoQmzk+BApXcSUs7qqyo3vZ XMCLA59ANmC/f/NSCoKufN90YXAwr5M31/KaBpYA8NosUeSJpl6maGrzRpxYPaZ3Qr+j JOu4L6SKlIq2cWJZhcOoKhjHQIgJ2Pub7JTsIIvXJ91/8y/tLNx7UBzhORtDa2jUeZuN 1UEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date :content-transfer-encoding:message-id:references:to; bh=yQskH8B9urJ9OkrCtjdI7iZAb6qTqmaqiI6B4IC99TA=; b=taL//wVDL2kAnF8wKJx46ZBpKlt6BMDAc/uB+YVv0tNM9m6962fFd0wax8GKItc2Dk +4BAo5xn1AJuif7Yh3KmYdpKSbJ9MfS9iQnA8PykXu5zaOal0Hx5DfCONznRZxqdiZ9L zQA77p14rTZbeo0AfvWFKxNC71lHDnHJaNVT00z6tESQ6Qh7YbF8LuFAyZbMyXUJHHdV un6J69sFeFmGZmoO1+P3L5uhyaz4WyYzQROtK1KVKa8HIGMnDU3Uz57Y1xrqOtFUrgU7 jLCKl9lvoiwHdpw43QW+cymSZly6Y0b8SjoLFPvyUhSVmjf2EjQ773qCJE5EiQpCzQX/ IQyA== X-Gm-Message-State: AIVw1116JRWHFQQpLlkZcWEqZ5UO44KLmPE39acjY1Y6MbSAmm6bj1yr mOTwJBy+GtUKulFSVtE= X-Received: by 10.28.128.67 with SMTP id b64mr3411019wmd.79.1500046448424; Fri, 14 Jul 2017 08:34:08 -0700 (PDT) Received: from [10.0.0.6] ([195.192.229.28]) by smtp.gmail.com with ESMTPSA id l46sm8513195wrl.15.2017.07.14.08.34.06 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 14 Jul 2017 08:34:07 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: Multipart From: Harbs In-Reply-To: Date: Fri, 14 Jul 2017 18:34:04 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <1B57D715-FA70-4820-BC9C-AAFD8D29A1EF@gmail.com> References: <8AE038BB-27D5-4F6A-9045-298F8EE33224@gmail.com> To: dev@flex.apache.org X-Mailer: Apple Mail (2.2104) archived-at: Fri, 14 Jul 2017 15:34:19 -0000 I contacted the other contributors. I already got permission from the one who did the critical fix. = (forwarded to the dev list) That only leaves one more who did = convenience code changes. We can remove that code if necessary. The document changes were not in the class file. It was to the readme in = the repo. Question: I assume that we keep the same package naming if we include it = on the repo unless it=E2=80=99s specifically donated to Apache. Correct? What about a modified class that I changed to work with FlexJS? Would = that get an apache package path or not? > On Jul 14, 2017, at 6:18 PM, Alex Harui = wrote: >=20 > AIUI, we are supposed to try to contact all contributors, no matter = how > small. If you don't hear from all of them, the PMC has to make a risk > assessment. If we take un-permitted lines of code and someone later > objects, could we quickly remove those lines of code and replace it? = Or, > should our initial check-in not include un-permitted lines of code and = the > first commits replace them? >=20 > Of course, I could be wrong... > -Alex >=20 > On 7/13/17, 2:40 PM, "Harbs" wrote: >=20 >> One of them was documentation edits. >>=20 >> Another was a workaround for a Flash permissions issue. It was a = sometime >> yes, sometimes no problem. I finally found where the problem lay that >> required that code. You can see the comments in old issues on that = repo. >> That piece of code is very necessary for Flash. There=E2=80=99s = really only one >> way to solve that particular issue. Not sure if he can own that = solution. >>=20 >> The third was some convenience methods. Not a major contribution. >>=20 >>> On Jul 14, 2017, at 12:07 AM, Alex Harui >>> wrote: >>>=20 >>> Made two comments in the GH issue. Looks like there were other >>> contributors so we may need to get their permission to make the = license >>> ALv2. >>>=20 >>> Of course, I could be wrong,... >>> -Alex >>>=20 >>> On 7/12/17, 9:14 PM, "Harbs" wrote: >>>=20 >>>> I don=E2=80=99t think he has plans on modifying it. >>>>=20 >>>> Do you mind making the suggestion about the header to the Github = issue? >>>>=20 >>>>> On Jul 13, 2017, at 7:10 AM, Alex Harui >>>>> wrote: >>>>>=20 >>>>> IMO, if the original author will be helping make changes to this = file, >>>>> we >>>>> want an ICLA. If he has no plans to work on it, then attaching it = to >>>>> a >>>>> JIRA would be sufficient documentation of his intent to donate it. >>>>>=20 >>>>> Either way, it would help if he put the 3rd-party ALv2 header in = the >>>>> file. >>>>>=20 >>>>> -Alex >>>>>=20 >>>>> On 7/12/17, 8:59 PM, "Harbs" wrote: >>>>>=20 >>>>>> In our repo with my modifications for FlexJS. >>>>>>=20 >>>>>>=20 >>>>>>> On Jul 13, 2017, at 1:22 AM, Alex Harui = >>>>>>> wrote: >>>>>>>=20 >>>>>>> What do you mean by "adopt". That the new home for further >>>>>>> improvements >>>>>>> is in our repo or that we're using it as a third-party = dependency? >>>>>>>=20 >>>>>>> -Alex >>>>>>>=20 >>>>>>> On 7/12/17, 12:45 PM, "Harbs" wrote: >>>>>>>=20 >>>>>>>> There=E2=80=99s a great class for uploading multi-part HTTP = requests. I=E2=80=99ve >>>>>>>> been >>>>>>>> using it for years, and I=E2=80=99ve ported it for use with = FlexJS. It >>>>>>>> works >>>>>>>> great in that context too. >>>>>>>>=20 >>>>>>>> I just asked the author if he minds if we adopt it and he=E2=80=99= s very >>>>>>>> happy >>>>>>>> for us to do so.[1] >>>>>>>>=20 >>>>>>>> It=E2=80=99s one class. Do we need to go through an ICLA, or = can we just >>>>>>>> bring >>>>>>>> it >>>>>>>> in with no fuss? >>>>>>>>=20 >>>>>>>> Thanks, >>>>>>>> Harbs >>>>>>>>=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>> = [1]https://na01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2F >>>>>>>> gi >>>>>>>> th >>>>>>>> ub >>>>>>>>=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>> = .com%2Fjimojon%2FMultipart.as%2Fissues%2F9&data=3D02%7C01%7C%7C61a62bf >>>>>>>> 56 >>>>>>>> 17 >>>>>>>> 14 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>> = 5e9929708d4c95e9650%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636 >>>>>>>> 35 >>>>>>>> 48 >>>>>>>> 55 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>> = 465043104&sdata=3D2SKnAIfWKXwDacqORK3Td9AyYffkEXBYr%2BTPdtm6efo%3D&res >>>>>>>> er >>>>>>>> ve >>>>>>>> d=3D >>>>>>>> 0=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>> = >>>>>>> th >>>>>>>> ub >>>>>>>> .c >>>>>>>>=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>> = om%2Fjimojon%2FMultipart.as%2Fissues%2F9&data=3D02%7C01%7C%7C61a62bf56 >>>>>>>> 17 >>>>>>>> 14 >>>>>>>> 5e >>>>>>>>=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>> = 9929708d4c95e9650%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63635 >>>>>>>> 48 >>>>>>>> 55 >>>>>>>> 46 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>> = 5043104&sdata=3D2SKnAIfWKXwDacqORK3Td9AyYffkEXBYr%2BTPdtm6efo%3D&reser >>>>>>>> ve >>>>>>>> d=3D >>>>>>>> 0> >>>>>>>=20 >>>>>>=20 >>>>>=20 >>>>=20 >>>=20 >>=20 >=20