flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Harbs <harbs.li...@gmail.com>
Subject Re: [FlexJS] technical debt
Date Tue, 18 Jul 2017 06:05:37 GMT
event.clone() is wrong for FlexJS. It’s event.cloneEvent()

There was other feedback on the dev list. That seemed to have been ignored.

A lot of the rules fly in the face to current convention in the SDK. Some (such as returning
from a constructor) are actually enforced by the compiler so the rule is not needed. I don’t
have time right now to get involved in a long protracted discussion, but please don’t take
the lack of input as consensus.

Feel free to do what you want to SonarQube now, but don’t make any changes based on the
reports. If anyone else takes an interest in it, please expect some rules to be changed.


> On Jul 18, 2017, at 8:50 AM, Justin Mclean <justin@classsoftware.com> wrote:
> Hi,
> So more than a week has gone by and I’ve received little feedback on [1]. Given that
I’ll gone ahead and implement the rules as discussed in the document so people can see the
> The new results are up:
> - First off the header rules is overly strict and expects a copyright line not just a
header. ASF policy to not to have copyright lines so this is a false positive. I’ll disable
the rule. We have other means to check headers. This will be fixed in the next run.
> - The ASDocs rule is picking a lot of public methods and properties that don’t have
ASDocs. I think we should keep this to remind us at some point it needs to be fixed / people
can fix as they make edits.
> - Is easier to see if issues that do need to be fixed. For instance I can see that there
are a couple of event.clone issues that are likely bugs.
> Thanks,
> Justin
> 1.  https://cwiki.apache.org/confluence/display/FLEX/Sonar+Cube+Flex+Rules <https://cwiki.apache.org/confluence/display/FLEX/Sonar+Cube+Flex+Rules>

View raw message