flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [3/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !== where needed
Date Wed, 21 Jun 2017 22:59:18 GMT
Hi,

Can you provide a bit more information on how it is broken? Can you point to any failing tests
for instance or provide sample code?

I’m using these changes in a project and have't noticed any issues and tests are still passing.

IMO it would be better to try and pinpoint the issue rather than revert all of the changes
which looks like you’ve done here.

For instance these lines have been incorrectly changed:
           var strpixels:String = positioner.style.width as String;
-            if (strpixels !== null && strpixels.indexOf('%') != -1)
+            if (strpixels !== null && strpixels.indexOf('%') !== -1)

Thanks,
Justin
Mime
View raw message