flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: Typedef issue causing flex-asjs to fail to compile
Date Wed, 15 Mar 2017 04:41:32 GMT

> It would not be my recommendation to have us add default parameters to all
> of the places we could for "code clarity" or performance. Folks who write
> code in ActionScript should know or can find from the documentation that,
> for example, the second parameter to parseInt is optional and thus would
> wonder why someone bothered to add it.  If the second parameter isn't
> there, the assumption should be that the default parameter is used.

The current SDK code uses  parseInt(number, ā€œ10ā€) in 29 different places.

This line which I fixed, was the only instance of parseInt(number).

Can you give a valid reason why I should revert it? So far Iā€™m not seeing one.

View raw message