Mailing-List: contact dev-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flex.apache.org
MIME-Version: 1.0
In-Reply-To: <18D82294-258F-4506-B29F-5C778C72A8D2@gmail.com>
References: <JIRA.12958392.1460533178978@arcas> <JIRA.12958392.1460533178000@Atlassian.JIRA>
 <JIRA.12958392.1460533178000.217294.1460541025493@Atlassian.JIRA>
 <CAP1cEXHq9_OYr+nAUckm5otsv0y2q4EMTpQraSzMRisPGpbk-g@mail.gmail.com>
 <37229ADD-B41C-4851-8203-9D2D3E2B2EEF@gmail.com> <CAP1cEXHJE7_391Sc2B1dO-yOOM8s-i7ym1PgSNJqXd8v=QnDvA@mail.gmail.com>
 <CAP1cEXGAVcTXb43PKkKvUaQBqk6Mpn3BVJ68HRir9eCx6kvkfA@mail.gmail.com>
 <CAP1cEXFhzhH3rU0k7VRDekUPDTYc5h6uriTM_F=3GJP9aUMV+Q@mail.gmail.com> <18D82294-258F-4506-B29F-5C778C72A8D2@gmail.com>
From: Mihai Chira <mihai.chira@gmail.com>
Date: Thu, 20 Oct 2016 10:45:15 +0200
Message-ID: <CAP1cEXGfVrWeeoMj7C8uHP2QZ-E_o1NqCrUUupDfOST6Nf_JEA@mail.gmail.com>
Subject: Re: [jira] [Comment Edited] (FLEX-35078) Fatal when SelectionManager
 tries to reapply selection onto changed textFlow
To: "dev@flex.apache.org" <dev@flex.apache.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 20 Oct 2016 08:50:43 -0000

No problem, and thanks for that, I appreciate it! Will email you a reminder=
.

On 20 October 2016 at 10:37, Harbs <harbs.lists@gmail.com> wrote:
> Hi Mihai,
>
> I forgot about this. I=E2=80=99m not going to have time to look into this=
 for at least a week or two.
>
> Please email me a reminder to take a look in a couple of weeks=E2=80=A6
>
> Harbs
>
> On Oct 20, 2016, at 11:29 AM, Mihai Chira <mihai.chira@gmail.com> wrote:
>
>> If anyone with TLF knowledge wants to take a look at this, it would be
>> quite helpful. Some of the investigation work is already done, and
>> someone who understands what _should_ happen can probably spot the
>> problem quickly. Thank you!
>>
>> On 29 August 2016 at 15:26, Mihai Chira <mihai.chira@gmail.com> wrote:
>>> Hi Harbs, just a quick reminder about this ticket, for when you have ti=
me.
>>>
>>> Many thanks!
>>> Mihai
>>>
>>> On 13 April 2016 at 12:54, Mihai Chira <mihai.chira@gmail.com> wrote:
>>>> Actually this bug seems to occur when the empty span is *not* removed.
>>>> Thanks for taking a look!
>>>>
>>>> On 13 April 2016 at 12:53, Harbs <harbs.lists@gmail.com> wrote:
>>>>> I think TLF is more aggressive than it used to be in removing empty s=
pans.
>>>>>
>>>>> I=E2=80=99ll try to look into this when I find the time.
>>>>>
>>>>> On Apr 13, 2016, at 1:22 PM, Mihai Chira <mihai.chira@gmail.com> wrot=
e:
>>>>>
>>>>>> Hey guys, I feel I've done as much as I can on this ticket to pave t=
he
>>>>>> way for someone with more TLF knowledge to hopefully have an easy ti=
me
>>>>>> understanding and fixing it. Do any of you have time to take a look?
>>>>>> Many thanks!
>>>>>>
>>>>>> On 13 April 2016 at 11:50, Mihai Chira (JIRA) <jira@apache.org> wrot=
e:
>>>>>>>
>>>>>>>   [ https://issues.apache.org/jira/browse/FLEX-35078?page=3Dcom.atl=
assian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D15238824#comment-15238824 ]
>>>>>>>
>>>>>>> Mihai Chira edited comment on FLEX-35078 at 4/13/16 9:49 AM:
>>>>>>> -------------------------------------------------------------
>>>>>>>
>>>>>>> * in {{TextFlowLine.makeSelectionBlocks()}} {{textLine.getAtomIndex=
AtCharIndex(27) =3D=3D -1}} although {{textLine.rawTextLength =3D=3D 37}}
>>>>>>> * after validation (see the *Workaround* in the ticket description)=
 the text flow
>>>>>>> {noformat}
>>>>>>> <TextFlow whiteSpaceCollapse=3D"preserve" version=3D"3.0.0" xmlns=
=3D"http://ns.adobe.com/textLayout/2008"><p><span fontSize=3D"15"></span><s=
pan>The bug is in the function TextFlowLine.adjustEndElementForBidi</span><=
/p></TextFlow>
>>>>>>> {noformat} is converted into {noformat}
>>>>>>> <TextFlow whiteSpaceCollapse=3D"preserve" version=3D"3.0.0" xmlns=
=3D"http://ns.adobe.com/textLayout/2008"><p><span>The bug is in the functio=
n TextFlowLine.adjustEndElementForBidi</span></p></TextFlow>{noformat}
>>>>>>> (where the empty span is where the bullet text used to be) and the =
fatal isn't thrown.
>>>>>>>
>>>>>>>
>>>>>>> was (Author: evolverine):
>>>>>>> * in {{TextFlowLine.makeSelectionBlocks()}} {{textLine.getAtomIndex=
AtCharIndex(27) =3D=3D -1}} although {{textLine.rawTextLength =3D=3D 37}}
>>>>>>> * after validation (see the *Workaround* in the ticket description)=
 the text flow
>>>>>>> {noformat}
>>>>>>> <TextFlow whiteSpaceCollapse=3D"preserve" version=3D"3.0.0" xmlns=
=3D"http://ns.adobe.com/textLayout/2008"><p><span fontSize=3D"15"></span><s=
pan>The bug is in the function TextFlowLine.adjustEndElementForBidi</span><=
/p></TextFlow>
>>>>>>> {noformat} is converted into {noformat}
>>>>>>> <TextFlow whiteSpaceCollapse=3D"preserve" version=3D"3.0.0" xmlns=
=3D"http://ns.adobe.com/textLayout/2008"><p><span>The bug is in the functio=
n TextFlowLine.adjustEndElementForBidi</span></p></TextFlow>{noformat}
>>>>>>> where the empty span is where the bullet text used to be.
>>>>>>>
>>>>>>>> Fatal when SelectionManager tries to reapply selection onto change=
d textFlow
>>>>>>>> ------------------------------------------------------------------=
----------
>>>>>>>>
>>>>>>>>               Key: FLEX-35078
>>>>>>>>               URL: https://issues.apache.org/jira/browse/FLEX-3507=
8
>>>>>>>>           Project: Apache Flex
>>>>>>>>        Issue Type: Bug
>>>>>>>>        Components: Spark: RichEditableText, TLF
>>>>>>>>  Affects Versions: Apache Flex 4.15.0
>>>>>>>>          Reporter: Mihai Chira
>>>>>>>>          Assignee: Mihai Chira
>>>>>>>>           Fix For: Apache Flex 4.16.0
>>>>>>>>
>>>>>>>>       Attachments: Main.mxml
>>>>>>>>
>>>>>>>>
>>>>>>>> *Steps to reproduce*:
>>>>>>>> * run the attached mxml
>>>>>>>> * click on the "Bullets" button
>>>>>>>> *Expected results*: the bullet text is removed from the paragraph =
and the RichEditableText is focused.
>>>>>>>> *Actual results*: the bullet text is removed, but when the focus m=
oves back to the RichEditableText component, the following fatal is thrown:
>>>>>>>> {noformat}
>>>>>>>> [Fault] exception, information=3DRangeError: Error #2006: The supp=
lied index is out of bounds.
>>>>>>>> at flash.text.engine::TextLine/getAtomBidiLevel()
>>>>>>>> at flashx.textLayout.compose::TextFlowLine/adjustEndElementForBidi=
()[C:\Users\evolverine\Adobe Flash Builder 4.7\FLEX-33058\src\flashx\textLa=
yout\compose\TextFlowLine.as:2499]
>>>>>>>> at flashx.textLayout.compose::TextFlowLine/makeSelectionBlocks()[C=
:\Users\evolverine\Adobe Flash Builder 4.7\FLEX-33058\src\flashx\textLayout=
\compose\TextFlowLine.as:1812]
>>>>>>>> at flashx.textLayout.compose::TextFlowLine/http://ns.adobe.com/tex=
tLayout/internal/2008::calculateSelectionBounds()[C:\Users\evolverine\Adobe=
 Flash Builder 4.7\FLEX-33058\src\flashx\textLayout\compose\TextFlowLine.as=
:1517]
>>>>>>>> at flashx.textLayout.compose::TextFlowLine/getSelectionShapesCache=
Entry()[C:\Users\evolverine\Adobe Flash Builder 4.7\FLEX-33058\src\flashx\t=
extLayout\compose\TextFlowLine.as:1428]
>>>>>>>> at flashx.textLayout.compose::TextFlowLine/createSelectionShapes()=
[C:\Users\evolverine\Adobe Flash Builder 4.7\FLEX-33058\src\flashx\textLayo=
ut\compose\TextFlowLine.as:1664]
>>>>>>>> at flashx.textLayout.compose::TextFlowLine/http://ns.adobe.com/tex=
tLayout/internal/2008::hiliteBlockSelection()[C:\Users\evolverine\Adobe Fla=
sh Builder 4.7\FLEX-33058\src\flashx\textLayout\compose\TextFlowLine.as:219=
6]
>>>>>>>> at flashx.textLayout.container::ContainerController/http://ns.adob=
e.com/textLayout/internal/2008::addSelectionShapes()[C:\Users\evolverine\wo=
rkspace\tlf\textLayout\src\flashx\textLayout\container\ContainerController.=
as:2920]
>>>>>>>> at flashx.textLayout.edit::SelectionManager/addSelectionShapes()[C=
:\Users\evolverine\workspace\tlf\textLayout\src\flashx\textLayout\edit\Sele=
ctionManager.as:1240]
>>>>>>>> at flashx.textLayout.edit::SelectionManager/refreshSelection()[C:\=
Users\evolverine\workspace\tlf\textLayout\src\flashx\textLayout\edit\Select=
ionManager.as:1272]
>>>>>>>> at flashx.textLayout.edit::SelectionManager/http://ns.adobe.com/te=
xtLayout/internal/2008::setSelectionFormatState()[C:\Users\evolverine\works=
pace\tlf\textLayout\src\flashx\textLayout\edit\SelectionManager.as:896]
>>>>>>>> at flashx.textLayout.edit::SelectionManager/focusInHandler()[C:\Us=
ers\evolverine\workspace\tlf\textLayout\src\flashx\textLayout\edit\Selectio=
nManager.as:2279]
>>>>>>>> at flashx.textLayout.container::ContainerController/focusInHandler=
()[C:\Users\evolverine\workspace\tlf\textLayout\src\flashx\textLayout\conta=
iner\ContainerController.as:2452]
>>>>>>>> at flashx.textLayout.container::TextContainerManager/focusInHandle=
r()[C:\Users\evolverine\workspace\tlf\textLayout\src\flashx\textLayout\cont=
ainer\TextContainerManager.as:2089]
>>>>>>>> at spark.components.supportClasses::RichEditableTextContainerManag=
er/focusInHandler()[C:\Users\evolverine\workspace\flex-sdk\frameworks\proje=
cts\spark\src\spark\components\supportClasses\RichEditableTextContainerMana=
ger.as:642]
>>>>>>>> at flashx.textLayout.container::ContainerController/http://ns.adob=
e.com/textLayout/internal/2008::requiredFocusInHandler()[C:\Users\evolverin=
e\workspace\tlf\textLayout\src\flashx\textLayout\container\ContainerControl=
ler.as:2470]
>>>>>>>> at flash.display::Stage/set focus()
>>>>>>>> at mx.core::UIComponent/setFocus()[C:\Users\evolverine\workspace\f=
lex-sdk\frameworks\projects\framework\src\mx\core\UIComponent.as:10437]
>>>>>>>> at spark.components::RichEditableText/setFocus()[C:\Users\evolveri=
ne\workspace\flex-sdk\frameworks\projects\spark\src\spark\components\RichEd=
itableText.as:3122]
>>>>>>>> at Main/bulletList_clickHandler()[C:\Users\evolverine\Adobe Flash =
Builder 4.7\FLEX-33058\src\Main.mxml:39]
>>>>>>>> at Main/__bulletsButton_click()[C:\Users\evolverine\Adobe Flash Bu=
ilder 4.7\FLEX-33058\src\Main.mxml:71]
>>>>>>>> {noformat}
>>>>>>>> *Workaround*: call {{display.validateNow();}} before {{display.set=
Focus();}}
>>>>>>>> *Notes*:
>>>>>>>> * couldn't reproduce the bug with only one line; we seem to need t=
he text to wrap around the second line.
>>>>>>>> * couldn't reproduce the bug if the span representing the bullet t=
ext wasn't set to an explicit font size (of any value).
>>>>>>>> * could reproduce the bug with many random (non-empty) strings for=
 the bullet text, including one space.
>>>>>>>> * could reproduce the bug when I set the fontWeight instead of the=
 fontSize on the bullet span. It seems that anything that will get the bull=
et placed into a separate span rather than merged with the span containing =
the main text will reproduce the bug.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> This message was sent by Atlassian JIRA
>>>>>>> (v6.3.4#6332)
>>>>>
>