flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject Re: [FlexJS] Overlapping default styles
Date Wed, 19 Oct 2016 17:09:57 GMT
Seems ok to me.  If no tests blow up, should be ok to push.

On 10/19/16, 1:56 AM, "carlos.rovira@gmail.com on behalf of Carlos Rovira"
<carlos.rovira@gmail.com on behalf of carlos.rovira@codeoscopic.com> wrote:

>Hi Alex,
>
>I made a change in a "feature/buttonbase-refactor"
>is tiny, but could potentially break things.
>
>This solves the problem, but I want to know your thinking about collateral
>damages in other code or examples.
>
>If you think is not what we need, I think I would go the route of
>extending
>from UIBase and replicate Button and TextButton in my component set.
>
>
>thanks
>
>
>2016-10-19 7:48 GMT+02:00 Alex Harui <aharui@adobe.com>:
>
>>
>>
>> On 10/18/16, 4:47 PM, "carlos.rovira@gmail.com on behalf of Carlos
>>Rovira"
>> <carlos.rovira@gmail.com on behalf of carlos.rovira@codeoscopic.com>
>> wrote:
>>
>> >I extended TextButton (ergo Button in the end), but I think carry all
>>its
>> >CSS is not what I expect...maybe I should not extend and replicate
>> >functionality extending UIBase
>>
>> Well, maybe.  I thought it would be easier to defeat these settings.  In
>> theory, if the mdl has CSS with these properties it would override the
>> properties in the defaults.css.  We could create a TextButtonBase in the
>> HTML.swc that you could extend and duplicate less code.
>> >
>> >I tried an empty defaults.css in my example project but nothing changes
>>
>> I guess that option does something different than I expected.  It sort
>>of
>> adds CSS files to the list, so there is no way to kick out some rules
>>you
>> don't want.  We could add a compiler option that really does reset all
>>of
>> the CSS in an app.
>>
>> -Alex
>>
>>
>
>
>-- 
>
>Carlos Rovira
>Director General
>M: +34 607 22 60 05
>http://www.codeoscopic.com
>http://www.avant2.es
>
>
>Este mensaje se dirige exclusivamente a su destinatario y puede contener
>información privilegiada o confidencial. Si ha recibido este mensaje por
>error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
>proceda a su destrucción.
>
>De la vigente Ley Orgánica de Protección de Datos (15/1999), le
>comunicamos
>que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
>S.A. La finalidad de dicho tratamiento es facilitar la prestación del
>servicio o información solicitados, teniendo usted derecho de acceso,
>rectificación, cancelación y oposición de sus datos dirigiéndose a
>nuestras
>oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
>necesaria.

Mime
View raw message