Mailing-List: contact dev-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flex.apache.org
From: Christofer Dutz <christofer.dutz@c-ware.de>
To: "'dev@flex.apache.org'" <dev@flex.apache.org>
Subject: [FLEXJS] Probably found the reason for some of my problems ...
Thread-Topic: [FLEXJS] Probably found the reason for some of my problems ...
Thread-Index: AQHRqH4kUcP6NhYs20a+b5c+odHDxg==
Date: Sat, 7 May 2016 16:33:56 +0000
Message-ID: <DB5PR05MB12859DC5F92F3DB5AF7729D7A27E0@DB5PR05MB1285.eurprd05.prod.outlook.com>
Accept-Language: de-DE, en-US
Content-Language: de-DE
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_DB5PR05MB12859DC5F92F3DB5AF7729D7A27E0DB5PR05MB1285eurp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2016 16:33:56.2653
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 9d387546-1437-4b89-846c-691d64a7e74d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB1285
archived-at: Sat, 07 May 2016 16:34:14 -0000

--_000_DB5PR05MB12859DC5F92F3DB5AF7729D7A27E0DB5PR05MB1285eurp_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Ok ... in a final struggle to at least have something to show at my talk at=
 ApacheCon I dug really deep into the compiler and noticed one thing:


There's a class called: JSSharedData, which contains a set of public static=
 variables for containing the state of a compilation (I guess). The problem=
 is that the values inside are set by the constructors of the compilers ...=
 well actually just MXMLJSC but as COMPJSC extends from that also from that=
. In the FlexJSToolGroup I create an instance of any tool the group has. Fi=
rst one of COMPJSC and then MXMLJSC. So when creating the MXMLJSC instance =
all the static global variables correctly initialized by COMPJSC are overwr=
itten by those of MXMLJSC. The reason I didn't notice this, was that in my =
last attempt I only used MXMLJSC in my examples from Flexmojos.


This "one state that's shared between compiler instances" is really bad as =
the VM isn't destroyed during the build, this means that eventually setting=
s from one module could leak to another module. I guess it would be absolut=
ely impossible to track down problems like this. "public static"-Variables =
for maintaining the State of an instance of anything is super-duper-ultra-b=
ad ... we have to change this.


Chris

--_000_DB5PR05MB12859DC5F92F3DB5AF7729D7A27E0DB5PR05MB1285eurp_--