Mailing-List: contact dev-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flex.apache.org
From: Christofer Dutz <christofer.dutz@c-ware.de>
To: "dev@flex.apache.org" <dev@flex.apache.org>
Subject: AW: FlexJS, JQuery and FDT
Thread-Topic: FlexJS, JQuery and FDT
Thread-Index: 
 AQHRm1TfoY3Hk5txskCbulJNZeHb4Z+TdFcAgAACBQCAAAEcAIAABnqAgAAR6ACAAGVxgIAAAVkAgAAC+oCAAAVqAIAAAS6AgAABOQCAAAC5gIAAKqqSgAACboCAAAir7IAABeaAgAAAl7aAAAuOgIAABQ5sgAAB7wCAAAHEZ4AABt4AgAAHrICAAANJgQ==
Date: Thu, 21 Apr 2016 12:59:13 +0000
Message-ID: 
 <DB5PR05MB128536305A90E9967D22912CA26E0@DB5PR05MB1285.eurprd05.prod.outlook.com>
References: <08481C36-740D-419D-9E85-EF7A1893C1F2@gmail.com>
 <D33D52E7.68222%aharui@adobe.com>
 <3B6419D2-E331-4898-8E99-24A07B6B423A@gmail.com>
 <D33D555F.68228%aharui@adobe.com>
 <B9737E44-B374-44D7-9491-E657A128C49D@gmail.com>
 <D33D69FE.68238%aharui@adobe.com>
 <4A80C78A-3E1D-41A0-A217-38845A0468C9@gmail.com>
 <CACK5iZeEpFZYi0ZgArmd2UPd4wxRsLFzwX+TvJRJgbdA=2h=tA@mail.gmail.com>
 <5D33EC56-8E59-4B78-8F18-B5F4D361C1B7@gmail.com>
 <D33DC70D.6825F%aharui@adobe.com>
 <394885FF-2FAF-4B89-A417-9C89A5D44FA5@gmail.com>
 <2A8FA2A7-FC67-4738-8424-A8F64ABBB38E@gmail.com>,<D33DC9BA.68269%aharui@adobe.com>
 <DB5PR05MB128518C83C6F82CA460D9D17A26E0@DB5PR05MB1285.eurprd05.prod.outlook.com>,<3BD7E6FC-99C4-457A-9A12-D25D9ED80B96@gmail.com>
 <DB5PR05MB12851E7DD3E7110366DBC6E2A26E0@DB5PR05MB1285.eurprd05.prod.outlook.com>,<C0491AAB-0230-4D22-9D17-B9D12E128884@gmail.com>
 <DB5PR05MB1285B24F2D7B1B41DF3600D6A26E0@DB5PR05MB1285.eurprd05.prod.outlook.com>,<85726B33-B510-4BA4-A3D7-66053CD9ABA5@gmail.com>
 <DB5PR05MB1285E2B768E01E211AAE6AF4A26E0@DB5PR05MB1285.eurprd05.prod.outlook.com>,<53AC97C2-AE05-4CDE-8E39-8597D324D501@gmail.com>
 <DB5PR05MB1285D5868C425E485C0976C4A26E0@DB5PR05MB1285.eurprd05.prod.outlook.com>
 <B94589F6-AD57-4304-A911-EB2294F881FA@gmail.com>,<458E6309-9B02-4C01-9AA1-30266D8E773A@gmail.com>
In-Reply-To: <458E6309-9B02-4C01-9AA1-30266D8E773A@gmail.com>
Accept-Language: de-DE, en-US
Content-Language: de-DE
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2016 12:59:13.1370
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 9d387546-1437-4b89-846c-691d64a7e74d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB1286


I really hate if I try to figure out things and I do a wipe-all and things =
work. It's an implication that somethings fundamentally wrong in the script=
s. But hopefully that will go away soon :-)

The bad thing is that I work with an LTE connection and bandwidth is limite=
d. This way I have to download stuff over and over again :-(

If the replacement should produce this:

/**
 * @const
 * @type {jQuery}
*/
var $ =3D jQuery;

I had to change the "/1" and "/2" in the replace string with "$1" and "$2".

Chris
________________________________________
Von: Harbs <harbs.lists@gmail.com>
Gesendet: Donnerstag, 21. April 2016 14:47:27
An: dev@flex.apache.org
Betreff: Re: FlexJS, JQuery and FDT

You are right. It did not seem to work.

I was not able to get flacon to build at all until I did wipe-all. Not sure=
 why. It was failing on the node swc. Maybe that=92s a clue for you.

The replacement was not run on the jquery file, but a manual GREP replaceme=
nt using the same parameters worked fine:
Find: (\* @const\s+)([\*\s/]+var \$)
Replace: \1* @type {jQuery}\n\2

Maybe I need to add a multiline flag?

On Apr 21, 2016, at 3:20 PM, Harbs <harbs.lists@gmail.com> wrote:

> It didn=92t add in @type?
>
> I edited the wiki with the intention.
>
> On Apr 21, 2016, at 2:57 PM, Christofer Dutz <christofer.dutz@c-ware.de> =
wrote:
>
>> I was hoping not to have to ... already wasted 3/4 of a day for this :-(
>>
>> But I just ran the Ant build with your replacement ... the output is ide=
ntical ... the "var $ =3D jQuery;" line seems to pass unchanged. Perhaps ex=
tending the description on the Wiki with the intention of the replacement c=
ould help (I usually add a comment to the replacement to tell others what t=
he regexp does as I don't tend to be able to fluently read regexps).
>>
>> Chris
>>
>> ________________________________________
>> Von: Harbs <harbs.lists@gmail.com>
>> Gesendet: Donnerstag, 21. April 2016 13:49
>> An: dev@flex.apache.org
>> Betreff: Re: FlexJS, JQuery and FDT
>>
>> I wish I knew. It=92s probably going to have to be Alex or Josh that ans=
wers this.
>>
>> Good luck!
>>
>> On Apr 21, 2016, at 2:44 PM, Christofer Dutz <christofer.dutz@c-ware.de>=
 wrote:
>>
>>> Taking this thread to develop ... :-)
>>>
>>> Thanks for that ... I would have missed that one ;-)
>>>
>>> Can you or someone else here explain why EXTERNC is commenting out tons=
 of methods in the maven version? It's generating identical code, but it's =
commenting out a lot of methods (not all) and therefore I can't build the J=
S externs anymore :-(
>>>
>>> This is sort of urgent, as I only have this and next week for working o=
n this sort of stuff.
>>>
>>> Chris
>>>
>>> ________________________________________
>>> Von: Harbs <harbs.lists@gmail.com>
>>> Gesendet: Donnerstag, 21. April 2016 13:24
>>> An: users@flex.apache.org
>>> Betreff: Re: FlexJS, JQuery and FDT
>>>
>>> Here you go:
>>> https://cwiki.apache.org/confluence/display/FLEX/@internal+changes+to+b=
uild+scripts
>>>
>>> On Apr 21, 2016, at 1:43 PM, Christofer Dutz <christofer.dutz@c-ware.de=
> wrote:
>>>
>>>> That would be a better solution, but I am hoping to eliminate the need=
 to replicate those types of changes soon.
>>>> But today I'm completely stuck with the JS externs no longer generatin=
g :-(
>>>>
>>>> Chris
>>>>
>>>> ________________________________________
>>>> Von: Harbs <harbs.lists@gmail.com>
>>>> Gesendet: Donnerstag, 21. April 2016 12:40
>>>> An: users@flex.apache.org
>>>> Betreff: Re: FlexJS, JQuery and FDT
>>>>
>>>> OK. Would it be easier to have a wiki page that we document build-rela=
ted changes in, so they are all in one place? We could send an email with a=
 link to the page when it=92s edited.
>>>>
>>>> On Apr 21, 2016, at 1:20 PM, Christofer Dutz <christofer.dutz@c-ware.d=
e> wrote:
>>>>
>>>>> If you change something ... write an email ... I'll replicate the cha=
nges.
>>>>> I just replicated the nodejs changes ... was quite an effort, but now=
 I'm back on track ... at least with that one ...
>>>>>
>>>>> Chris
>>>>>
>>>>> ________________________________________
>>>>> Von: Harbs <harbs.lists@gmail.com>
>>>>> Gesendet: Donnerstag, 21. April 2016 11:48
>>>>> An: users@flex.apache.org
>>>>> Betreff: Re: FlexJS, JQuery and FDT
>>>>>
>>>>> OK. Can you recommend a workflow so these changes are properly captur=
ed?
>>>>>
>>>>> On Apr 21, 2016, at 12:40 PM, Christofer Dutz <christofer.dutz@c-ware=
.de> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> just a request from my side, If you adjust any of the pre-/post-proc=
essing scripts or change javascript downloads, please inform me about that =
cause these are impossible to auto-merge and even harder to detect.
>>>>>>
>>>>>> Chris
>>>>>>
>>>>>> ________________________________________
>>>>>> Von: Alex Harui <aharui@adobe.com>
>>>>>> Gesendet: Donnerstag, 21. April 2016 09:07
>>>>>> An: users@flex.apache.org
>>>>>> Betreff: Re: FlexJS, JQuery and FDT
>>>>>>
>>>>>> We do these kinds of changes with Ant replace and replaceregex in th=
e
>>>>>> build.xml.  See the top-level build.xml and the externc.js.swc targe=
t.
>>>>>>
>>>>>> -Alex
>>>>>>
>>>>>> On 4/21/16, 12:04 AM, "Harbs" <harbs.lists@gmail.com> wrote:
>>>>>>
>>>>>>> Bah. .gitignore has this entry: externs/jquery/externs
>>>>>>>
>>>>>>> Is there any way to make this change and have it =93stick=94 in the=
 repo?
>>>>>>>
>>>>>>> On Apr 21, 2016, at 10:00 AM, Harbs <harbs.lists@gmail.com> wrote:
>>>>>>>
>>>>>>>> OK. I=92ll make that change. I don=92t have time to test today, so=
 I=92ll see
>>>>>>>> what happens in the next nightly=85
>>>>>>>>
>>>>>>>> On Apr 21, 2016, at 9:55 AM, Alex Harui <aharui@adobe.com> wrote:
>>>>>>>>
>>>>>>>>> I think it should be:
>>>>>>>>>
>>>>>>>>> /**
>>>>>>>>> * @const
>>>>>>>>> * @type {jQuery}
>>>>>>>>> */
>>>>>>>>> var $ =3D jQuery;
>>>>>>>>>
>>>>>>>>> Look at other extern files for similar usage.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> -Alex
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On 4/20/16, 11:36 PM, "Harbs" <harbs.lists@gmail.com> wrote:
>>>>>>>>>
>>>>>>>>>> Yes. I was looking in asjs instead of falcon=85
>>>>>>>>>>
>>>>>>>>>> I=92ve never done typdefs before. Does this look right?
>>>>>>>>>>
>>>>>>>>>> /**
>>>>>>>>>> * @const
>>>>>>>>>> * @typedef {jQuery}
>>>>>>>>>> */
>>>>>>>>>> var $ =3D jQuery;
>>>>>>>>>>
>>>>>>>>>> It=92s currently:
>>>>>>>>>> /**
>>>>>>>>>> * @const
>>>>>>>>>> */
>>>>>>>>>> var $ =3D jQuery;
>>>>>>>>>>
>>>>>>>>>> On Apr 21, 2016, at 9:25 AM, OmPrakash Muppirala
>>>>>>>>>> <bigosmallm@gmail.com>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> I think this is what you are looking for?
>>>>>>>>>>> : flex-falcon\externs\jquery\externs\jquery-1.9.js
>>>>>>>>>>>
>>>>>>>>>>> Thanks,
>>>>>>>>>>> Om
>>>>>>>>>>>
>>>>>>>>>>> On Wed, Apr 20, 2016 at 11:21 PM, Harbs <harbs.lists@gmail.com>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> I=92m looking for where the jQuery definitions are and I can=
=92t seem to
>>>>>>>>>>>> find
>>>>>>>>>>>> it.
>>>>>>>>>>>>
>>>>>>>>>>>> On Apr 21, 2016, at 3:17 AM, Alex Harui <aharui@adobe.com> wro=
te:
>>>>>>>>>>>>
>>>>>>>>>>>>> Looks like the externs file doesn't have an @type for the $
>>>>>>>>>>>>> constant.
>>>>>>>>>>>> You
>>>>>>>>>>>>> can try adding it in the build script or see if Google will a=
ccept
>>>>>>>>>>>>> a
>>>>>>>>>>>> patch
>>>>>>>>>>>>> for it.
>>>>>>>>>>>>>
>>>>>>>>>>>>> -Alex
>>>>>>>>>>>>>
>>>>>>>>>>>>> On 4/20/16, 4:13 PM, "Harbs" <harbs.lists@gmail.com> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Replacing =93$=94 with =93jQuery=94 makes the warnings go aw=
ay. Why would
>>>>>>>>>>>>>> =93$=94 be
>>>>>>>>>>>>>> different than =93jQuery=94? It sounds to me like a bug in t=
he
>>>>>>>>>>>>>> definitions.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> jQuery always returns a JQuery object which has many defined
>>>>>>>>>>>>>> methods.
>>>>>>>>>>>> One
>>>>>>>>>>>>>> of those is attr.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Apr 21, 2016, at 1:50 AM, Alex Harui <aharui@adobe.com> w=
rote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> IMO, this is why Jquery is painful for strong typing.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I think you may need to do casting:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> ($("#topcoat") as Whatever).attr(..)
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Where Whatever is a "type" that has an attr function.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> And you may need to use @flexjsignorecoercion or other comp=
iler
>>>>>>>>>>>>>>> options
>>>>>>>>>>>>>>> to
>>>>>>>>>>>>>>> not actually do the "as" test in the JS output.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Good luck,
>>>>>>>>>>>>>>> -Alex
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On 4/20/16, 3:46 PM, "Harbs" <harbs.lists@gmail.com> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Here=92s an example:
>>>>>>>>>>>>>>>> $("#topcoat").attr("href",
>>>>>>>>>>>>>>>> "css/topcoat-desktop-lightlight.min.css");
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> It looks like =93$=94 is defined as an object.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Here=92s the exact warnings I=92m getting:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Could not resolve variable (may be a dynamic member) 'attr=
' at
>>>>>>>>>>>>>>>> line 43
>>>>>>>>>>>>>>>> column 19. ThemeManager.as /MyExtension/src/com/unhurdle
>>>>>>>>>>>>>>>> Unknown
>>>>>>>>>>>> Flash
>>>>>>>>>>>>>>>> Problem
>>>>>>>>>>>>>>>> Maybe invoking a non function. Found
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> $("#topcoat").attr("href","css/topcoat-desktop-lightlight.=
min.css
>>>>>>>>>>>>>>>> ");
>>>>>>>>>>>> at
>>>>>>>>>>>>>>>> line 43 column
>>>>>>>>>>>>>>>> 5. ThemeManager.as /MyExtension/src/com/unhurdle   Unknown=
 Flash
>>>>>>>>>>>> Problem
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> And yes, js/libs/jquery.swc is included. If I remove it, I=
 get
>>>>>>>>>>>>>>>> an
>>>>>>>>>>>> error
>>>>>>>>>>>>>>>> that =93$=94 is not defined instead of a warning.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Apr 21, 2016, at 1:39 AM, Alex Harui <aharui@adobe.com>
>>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On 4/20/16, 3:34 PM, "Harbs" <harbs.lists@gmail.com> wrot=
e:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Does anyone know if there=92s a way to get FDT to not fl=
ag
>>>>>>>>>>>>>>>>>> JQuery
>>>>>>>>>>>>>>>>>> expressions with =93could not resolve variable=94 and "M=
aybe
>>>>>>>>>>>>>>>>>> invoke a
>>>>>>>>>>>> non
>>>>>>>>>>>>>>>>>> function=94 warnings?
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> What kind of expressions result in this output?  Are you =
sure
>>>>>>>>>>>>>>>>> you
>>>>>>>>>>>> have
>>>>>>>>>>>>>>>>> the
>>>>>>>>>>>>>>>>> jquery.swc from the externs on the -external-library-path=
?
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> -Alex
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>