Return-Path: X-Original-To: apmail-flex-dev-archive@www.apache.org Delivered-To: apmail-flex-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BC615188A5 for ; Tue, 5 Jan 2016 21:06:38 +0000 (UTC) Received: (qmail 84430 invoked by uid 500); 5 Jan 2016 21:06:38 -0000 Delivered-To: apmail-flex-dev-archive@flex.apache.org Received: (qmail 84391 invoked by uid 500); 5 Jan 2016 21:06:38 -0000 Mailing-List: contact dev-help@flex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flex.apache.org Delivered-To: mailing list dev@flex.apache.org Received: (qmail 84380 invoked by uid 99); 5 Jan 2016 21:06:38 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2016 21:06:38 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 069B8DFFAE; Tue, 5 Jan 2016 21:06:38 +0000 (UTC) From: adufilie To: dev@flex.apache.org Reply-To: dev@flex.apache.org References: In-Reply-To: Subject: [GitHub] flex-falcon pull request: Compiler fixes related to js.swc Content-Type: text/plain Message-Id: <20160105210638.069B8DFFAE@git1-us-west.apache.org> Date: Tue, 5 Jan 2016 21:06:38 +0000 (UTC) Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169134018 This is outputting ActionScript code to correspond to the JavaScript APIs, so I don't think the requirement of an AS3 namespace on Number.prototype.toString() etc. is necessary. I would argue that it is better to have less special-case code in the compiler. The patched code outputs toString() in all the generated AS files where it appears in the JS externs except Object.as, where before it only appeared in Number/int/uint. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---