flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christofer Dutz <christofer.d...@c-ware.de>
Subject AW: AW: AW: [VOTE] Remove the Ant scripts from BlazeDS?
Date Thu, 31 Dec 2015 12:55:02 GMT
Hi Alex,

1) The poms are all there ... so you should simply copy them. After all that's all what maven
does.
2) I didn't want to hard-code the ports as I wanted the thing to run on the Apache build servers
and you never know which port is being used by another job/service/... so the server starts
up, reports it's port and passes that to the tests. 
3) I don't know what Jgroups is used for ... it was always in the build. I would assume that
it's used for running BlazeDS in a cluster environment. 
4) You are probably talking about the JMS API and not a real JMS. I guess that in both cases
the API should be identical as long as it's the same API version. But as JMS hasn't changed
that much I bet you would be safe, but it would be even better if we all used the same.

I was thinking about refactoring these tests to become Integration-Tests as I don't think
a Unit Test should require a server to be started. With this split-up the unit-tests on the
azure would run and the integration-tests could be run on the ASF build servers (Which should
be the main ones)

Would it be ok for me to take your Ant scripts, add them to the 4.8.0 branch and adjust the
things that need to be changed? As soon as all is working there, I would merge 4.8.0 back
to develop (even if this is going to be a quite forceful commit).

Chris

________________________________________
Von: Alex Harui <aharui@adobe.com>
Gesendet: Mittwoch, 30. Dezember 2015 16:14
An: dev@flex.apache.org
Betreff: Re: AW: AW: [VOTE] Remove the Ant scripts from BlazeDS?

OK, on the apacheflexbuilds CI server, I added a new build that runs the
Ant script and it is now successful.  I also got the Maven build back to
an "operational" state but lots of tests fail there.

Some open issues:

1) The Ant build currently builds the same set of jars, but puts them all
in a lib folder and does not add maven information in the jars.  This was
the minimum set of changes from the old scripts that I think produces
something useful for folks not using Maven.  The question is how important
it is to add all the Maven stuff and output to the same output folders.

2) The Maven build seems like it cannot run its tests because the tests
try to spin up a series of servers in a port range that is not open on
this Azure VM and there doesn't seem to be a practical way to open a range
of ports.  Is there a way to configure the tests to only need one or two
ports?

3) The Ant build currently does not include the Jgroups dependency.
Should it?  It appears that the Jgroups currently used by the Maven build
is not new enough to be licensed with an Apache-friendly license.

4) The version of JMS being used by the Maven build appears to be using
looks like it is under CDDL with the GPL Class Path exception which
appears to be on the Category X list [1].  In the Ant build, I am using
the JMS that came with ActiveMQ.  What is the right thing to do here?

Anyway, if you want to do more refactoring, go ahead.  I learned a bit
more about Maven and it hopefully won't take me as long to re-sync and
maybe apply the decisions on these open issues.

Thoughts?
-Alex

[1] http://www.apache.org/legal/resolved.html


On 12/28/15, 8:19 AM, "Christofer Dutz" <christofer.dutz@c-ware.de> wrote:

>It should only be the names of some directories ...
>
>Guess the problem was me switching the branches to 4.8.0 and still having
>the src/main/java structure because of uncommitted files. I'd even do the
>changes myself as soon as you committed yours.
>
>Chris
>
>________________________________________
>Von: Alex Harui <aharui@adobe.com>
>Gesendet: Montag, 28. Dezember 2015 16:42
>An: dev@flex.apache.org
>Betreff: Re: AW: [VOTE] Remove the Ant scripts from BlazeDS?
>
>Not sure I understand the issue, but I am just now testing the Ant build
>for BlazeDS on the apacheflexbuilds CI server.  I spent time over the past
>several days getting it to work in the develop branch.  I'd prefer not to
>have to start over, although I would imagine that most of what I did would
>still apply or only need minor tweaking.
>
>-Alex
>
>On 12/28/15, 7:15 AM, "Christofer Dutz" <christofer.dutz@c-ware.de> wrote:
>
>>Öhm ... just noticed who actually wrote that last message :-) Sorry for
>>the over-detailled email.
>>
>>Just started comparing the develop and the 4.8.0 branch and there were
>>quite I lot of changes I did. Especially in bringing the directory
>>structure to a default maven structure. I actually didn't quite notice
>>this as my IDE hid the details of the structure.
>>
>>What do you think ... 4.8.0 is a full blown maven default structure ...
>>re-doing all of that is quite some effort. Especially cleaning up the
>>tomcat projects.
>>
>>Would it be another option to add the Ant build to 4.8.0 and to merge
>>that to develop as soon as it's done?
>>
>>Chris
>>
>>________________________________________
>>Von: Christofer Dutz
>>Gesendet: Montag, 28. Dezember 2015 16:07
>>An: dev@flex.apache.org
>>Betreff: AW: [VOTE] Remove the Ant scripts from BlazeDS?
>>
>>Well actually I was thinking about dropping that branch, as I re-did the
>>cleanup in the develop branch. I still kept it there in order to find out
>>if I did any changes that I missed. But I just checked and I could easily
>>build 4.8.0. Having a deeper look at the code however I did notice that
>>in the parent chain one level was skipped. This can cause problems when
>>building the first time. I fixed this and now these problems shouldn't
>>occur any more, but I would strongly suggest not to work on the 4.8.0
>>branch ... I have to clean this up first.
>>
>>The main reason for this was that I did some changes in the structure
>>that were not backed by the majority of the Flex project, so I started
>>from develop again and re did only the changed that have public backing.
>>
>>Thinking about it, It should actually be the ideal time to do that right
>>away ... I'll keep you posted on my progress.
>>
>>Chris
>>
>>________________________________________
>>Von: Justin Mclean <justinmclean@me.com>
>>Gesendet: Montag, 28. Dezember 2015 03:04
>>An: dev@flex.apache.org
>>Betreff: Re: [VOTE] Remove the Ant scripts from BlazeDS?
>>
>>Hi,
>>
>>> So anyone else following this ... in order to build develop now all you
>>>should need is: "mvn install"
>>
>>Tried it out on the 4.8.0 branch and got these errors:
>>
>>[ERROR] The build could not read 3 projects -> [Help 1]
>>[ERROR]
>>[ERROR]   The project
>>org.apache.flex.blazeds:flex-messaging-opt-tomcat-4:[unknown-version]
>>(/Users/justinmclean/Documents/flex-blazeds/opt/tomcat/tomcat-4/pom.xml)
>>has 1 error
>>[ERROR]     Non-resolvable parent POM: Could not find artifact
>>org.apache.flex.blazeds:flex-messaging-opt:pom:4.8.0-SNAPSHOT and
>>'parent.relativePath' points at wrong local POM @ line 22, column 10 ->
>>[Help 2]
>>[ERROR]
>>[ERROR]   The project
>>org.apache.flex.blazeds:flex-messaging-opt-tomcat-6:[unknown-version]
>>(/Users/justinmclean/Documents/flex-blazeds/opt/tomcat/tomcat-6/pom.xml)
>>has 1 error
>>[ERROR]     Non-resolvable parent POM: Could not find artifact
>>org.apache.flex.blazeds:flex-messaging-opt:pom:4.8.0-SNAPSHOT and
>>'parent.relativePath' points at wrong local POM @ line 22, column 10 ->
>>[Help 2]
>>[ERROR]
>>[ERROR]   The project
>>org.apache.flex.blazeds:flex-messaging-opt-tomcat-7:[unknown-version]
>>(/Users/justinmclean/Documents/flex-blazeds/opt/tomcat/tomcat-7/pom.xml)
>>has 1 error
>>[ERROR]     Non-resolvable parent POM: Could not find artifact
>>org.apache.flex.blazeds:flex-messaging-opt:pom:4.8.0-SNAPSHOT and
>>'parent.relativePath' points at wrong local POM @ line 22, column 10 ->
>>[Help 2]
>>
>>Running on OS X and tried java 1.7 and 1.8
>>
>>Thanks,
>>Justin
>>
>


Mime
View raw message