flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Harbs <harbs.li...@gmail.com>
Subject Re: [TLF Unit Tests]
Date Sun, 27 Dec 2015 19:56:03 GMT
Well, I tried explicitly setting the font, and nothing I tried helped.

I’m leaving it alone for now. If anyone wants to try and fix the tests, feel free…

On Dec 27, 2015, at 5:21 PM, Alex Harui <aharui@adobe.com> wrote:

> Any Flex-based app should default to Verdana or Arial unless specified
> otherwise.  Not sure what AS-only apps will do.
> 
> On 12/27/15, 1:50 AM, "Harbs" <harbs.lists@gmail.com> wrote:
> 
>> I just looked at it. It’s definitely not using embedded fonts. I also do
>> not see where it’s specifying the font used. On Mac it seems to be
>> defaulting to Times New Roman. Any idea what it defaults to on Windows?
>> 
>> On Dec 27, 2015, at 9:35 AM, Alex Harui <aharui@adobe.com> wrote:
>> 
>>> I have a Macbook Retina 15" as well.  I don't normally run these tests
>>> but
>>> I just tried it and got 6 failures as well.
>>> I purposefully didn't sync up before running tests.  My log has the last
>>> commit on Oct 19.
>>> 
>>> I only found the word "embedAsCFF" in AliceScrollEmbed.as so that sort
>>> of
>>> implies that fonts aren't embedded in most SWFs so that could certainly
>>> result in line break differences which can cause PageUp to go to
>>> different
>>> lines.
>>> 
>>> HTH,
>>> -Alex
>>> 
>>> On 12/26/15, 10:24 PM, "Harbs" <harbs.lists@gmail.com> wrote:
>>> 
>>>> I would think there wouldn’t be a difference. I don’t know if the fonts
>>>> are embedded. Do the tests pass for you on Mac? Maybe it’s a
>>>> retina-specific difference? (I’m running the tests on a 15 in MacBook
>>>> Pro
>>>> Retina.)
>>>> 
>>>> The odd thing is that I’m pretty sure that I did not used to get these
>>>> failures. Were they disabled and then at some point and then enabled?
>>>> 
>>>> I’m personally not overly concerned if there are some small differences
>>>> in scrolling using page up on different systems, but I would like to
>>>> understand what’s going on…
>>>> 
>>>> On Dec 27, 2015, at 8:16 AM, Alex Harui <aharui@adobe.com> wrote:
>>>> 
>>>>> 
>>>>> 
>>>>> On 12/26/15, 10:06 PM, "Harbs" <harbs.lists@gmail.com> wrote:
>>>>> 
>>>>>> A couple of things:
>>>>>> 
>>>>>> Item I:
>>>>>> 
>>>>>> There are six tests which have been constantly failing on my machine
>>>>>> for
>>>>>> a long time. They are all in KeyboardGestureTests, and they are all
>>>>>> tests
>>>>>> for page up gestures. It looks to me that the resulting indexes are
>>>>>> different from the expected ones. I adjusted the test outputs to
show
>>>>>> the
>>>>>> differences and here they are:
>>>>>> 1. pgUpGeneralTest: PgUp failed to select 7/8 page up. Expected
>>>>>> 3332,3332
>>>>>> but got 3320,3320 instead.
>>>>>> 2. shiftPageUpLocationTest: Shift-PageUp failed to move up from image
>>>>>> sandwich. Expected 460,608 but got 457,608 instead.
>>>>>> 3. shiftPgUpGeneralTest: Shift-PageUp failed to select 7/8 page up.
>>>>>> Expected 3332,6067 but got 3320,6067 instead.
>>>>>> 4. pgUpLocationTest: PageUp failed to move up from image sandwich.
>>>>>> Expected 460,460 but got 457,457 instead.
>>>>>> 5. pgUpLanguageTest: PageUp changed movement behavior within right
to
>>>>>> left text. Expected 12,12 but got 51,51 instead.
>>>>>> 6. shiftPageUpLanguageTest: Shift-PageUp changed movement behavior
>>>>>> within
>>>>>> right to left text. Expected 12,261 but got 51,261 instead.
>>>>>> 
>>>>>> Where do the expected values come from? Could there be a difference
>>>>>> between Windows and Mac?
>>>>> 
>>>>> Don't know for sure.  Should TLF have differences between Mac and Win
>>>>> if
>>>>> the fonts are embedded?  Are the fonts embedded?
>>>>> 
>>>>> HTH,
>>>>> -Alex
>>>>> 
>>>> 
>>> 
>> 
> 


Mime
View raw message