flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject Re: [GitHub] flex-sdk pull request: Replace string concatenation as argument St...
Date Fri, 30 Oct 2015 16:49:41 GMT
Hi SlavaRa,

Do you have a link that supports your claim that the compiler cannot
generate the correct optimization?  This article seems to imply that it
can [1]

IMO, the string concatenation is easier to read.  I would want to see
actual profiling that shows that the string concatenation is affecting
compile times in a significant way.

But the most important question to me is:  Is there a reason you want to
work on the mxmlc compiler?  The “falcon” compiler in the flex-falcon repo
is under much more active development and it would be lower risk to be
doing optimizations in that code base.  The “falcon” compiler is the
compiler for the new FlexJS framework and I believe there is still a
reasonable chance it could replace the mxmlc compiler in Flex SDKs some
day.

-Alex

[1] 
http://stackoverflow.com/questions/1532461/stringbuilder-vs-string-concaten
ation-in-tostring-in-java

On 10/30/15, 5:00 AM, "SlavaRa" <git@git.apache.org> wrote:

>Github user SlavaRa commented on the pull request:
>
>    https://github.com/apache/flex-sdk/pull/24#issuecomment-152506154
>  
>    "I think "looks bad" is a personal preference."
>    Perhaps, but in this situation, combined the two approaches
>StringBuffer.append and string concatenations.. in this case, the
>compiler can not generate correct optimization.
>
>
>
>---
>If your project is set up for it, you can reply to this email and have
>your
>reply appear on GitHub as well. If your project does not have this feature
>enabled and wishes so, or if the feature is enabled but not working,
>please
>contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>with INFRA.
>---

Mime
View raw message