flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject Re: [FlexJS] Framework using externs (was: Setup Error)
Date Wed, 16 Sep 2015 16:54:06 GMT
Hi Fred,

I started poking around in the branch.  I’m confused by how you plan to
use the conditional compilation flags.  Whole classes seem to be marked
with COMPILE::AS3, but I would expect any conditional compilation to be on
or inside methods.  Can you explain?


On 9/16/15, 2:26 AM, "Frédéric THOMAS" <webdoublefx@hotmail.com> wrote:

>Hi Alex,
>Cool, Btw, I didn't fix the bug I had with the flex-oem-compiler yet
>given I will move those things to IJ, neither the one regarding the
>getter / setter functions at package level.
>I will share the CGL.swc with its sources and details as soon as I can,
>probably tomorrow along with the Ant targets using the compiler.clients.*
>Frédéric THOMAS
>> From: aharui@adobe.com
>> To: dev@flex.apache.org
>> Subject: Re: [FlexJS] Framework using externs (was: Setup Error)
>> Date: Wed, 16 Sep 2015 06:08:33 +0000
>> FYI, I’m going to start finding time to work on this port.
>> -Alex
>> On 9/9/15, 6:19 AM, "Alex Harui" <aharui@adobe.com> wrote:
>> >
>> >
>> >On 9/9/15, 3:12 AM, "Frédéric THOMAS" <webdoublefx@hotmail.com> wrote:
>> >
>> >>
>> >>One thing I discovered though is that with Falcon, the combination of
>> >>getter / setter for a same function at package level is not supported
>> >>(the legacy compiler support it):
>> >>
>> >>package goog.events {
>> >>public function get fireListener():Function{return null;}
>> >>public function set fireListener(value:Function):void{}
>> >>}
>> >>
>> >>Error: An externally-visible definition with the name
>> >>'goog.events.fireListener' was unexpectedly found.
>> >>
>> >>Can you take care of it or drive me into fixing it ?
>> >
>> >That’s interesting.  I’ve never seen a ‘global’ property in AS before.
>> If
>> >you want to try to fix it, what I would do is set a breakpoint in
>> >CompilerProblem.java.  Then you’ll see on the call stack what logic
>> >decided to generate that error and can try to add other logic to
>>accept it
>> >in this case.
>> >
>> >Speaking of doing things like that, it occurred to me recently that
>> >ambiguous definition errors when the global Event class conflicts with
>> >org.apache.flex.events.Events could be handled by adjusting the logic
>> >detecting ambiguous definitions.  IIRC, the logic resolves the “Event”
>> >if it finds more than one definition it generates the error.  The logic
>> >could be adjusted to see if one of the definitions is a global
>> >and then use the global and maybe additionally generate a warning
>> >of an error.	 	   		
>> >BTW, it looks like this week and next will be spent on getting a
>> >out the door, then I hope to work on this port from JS to AS.
>> >
>> >-Alex
>> >

View raw message