flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Frédéric THOMAS <webdoubl...@hotmail.com>
Subject RE: Re : Re: [FlexJS] Framework using externs (was: Setup Error)
Date Tue, 11 Aug 2015 12:22:08 GMT
> Well, try running ‘ant main’, then in examples/DataBindingTest run Ant
> again and see if you get any errors or warnings. Maybe something changed
> so that isn’t needed anymore. You might just want to use a new
> compile-js-config.xml file.

Until Core is not totally migrated, that won't be possible.

I've seen in core/asjs, the default.css but haven't seen where it is used.

> What is the advantage of doing it this way?

My point in migrating the framework is also to figure out how a framework developer would
feel comfortable working with, using and developing new component seeing how the others are
developed, for example, even though this class is emitted in JS only, it is now coded in AS,
except of the comments I added to this class which is a wrapper to the goog.events.BrowserEvent,
if he needs to use it, the developer will probably look at the google doc too and I guess,
expect to have as close as possible the same API.

Well, at least I did this assumption and was wondering if it wasn't to much.

Frédéric THOMAS


----------------------------------------
> From: aharui@adobe.com
> To: dev@flex.apache.org
> Subject: Re: Re : Re: [FlexJS] Framework using externs (was: Setup Error)
> Date: Tue, 11 Aug 2015 06:37:13 +0000
>
>
>
> On 8/10/15, 11:05 AM, "Frédéric THOMAS" <webdoublefx@hotmail.com> wrote:
>
>>I even removed the entire <library-path> section and I've have no
>>compilation errors and the core tests passes, is that enough to ensure it
>>can be safely removed ?
>
> Well, try running ‘ant main’, then in examples/DataBindingTest run Ant
> again and see if you get any errors or warnings. Maybe something changed
> so that isn’t needed anymore. You might just want to use a new
> compile-js-config.xml file.
>
>>
>>Another thing, I see that in BrowserEvent.js
>>
>>/**
>> * @type {?goog.events.BrowserEvent}
>> */
>>org.apache.flex.events.BrowserEvent.prototype.wrappedEvent = null;
>>
>>There is no extern definition for the GCL, I type those as Object, is it
>>fine ?
>
> That file contains some dirty hacks, maybe we just won’t cross-compile it.
>
>>
>>I added some missing potentially other properties and functions to this
>>class, one of them required an enum, instead, I did like that:
>>
>>package org.apache.flex.core.BrowserEvent {
>>
>>COMPILE::AS3
>>internal class MouseButton {}
>>
>>COMPILE::JS
>>public class MouseButton {
>> public static const LEFT:MouseButton = new MouseButton(0, "LEFT");
>> public static const MIDDLE:MouseButton = new MouseButton(1, "MIDDLE");
>> public static const RIGHT:MouseButton = new MouseButton(2, "RIGHT");
>>
>> private var _index:uint;
>> private var _name:String;
>>
>> public function MouseButton(index:uint, name:String):void {
>> _index = index;
>> _name = name;
>>
>> }
>>
>> public function get index():uint {
>> return _index;
>> }
>>
>> public function get name():String {
>> return _name;
>> }
>>}
>>}
>>
>>
>>Is it ok or it is overkilling ?
>
> What is the advantage of doing it this way?
>
> Thanks for working on this,
> Alex
>
>
 		 	   		  
Mime
View raw message