flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Frédéric THOMAS <webdoubl...@hotmail.com>
Subject RE: [FalconJX] Code formatting
Date Mon, 29 Jun 2015 16:44:26 GMT
> No real objections here. I’m not a huge fan of automatic line-length
> requirements. To me, there is some art to formatting code.

I agree with that, to me it should be at least more a structural formatting
than an automatic one, but if we should have one, I would prefer 120.

Actually, I remember having using it for Randori and
the continuous line wrapping didn't help at all, I guess it was ok when 
I had a 15' screen but now it makes the code too complicated to read.

I had to switch back to 120 instead of 80 for:

<setting id="org.eclipse.jdt.core.formatter.alignment_for_conditional_expression" value="120"/>
<setting id="org.eclipse.jdt.core.formatter.lineSplit" value="120"/>
<setting id="org.eclipse.jdt.core.formatter.comment.line_length" value="120"/>
<setting id="org.eclipse.jdt.core.formatter.alignment_for_resources_in_try" value="120"/>

I won't object more than that if folks prefer 80 but for sure that won't be
a pleasant experience to me.

For the rest of the formatting, I'm ok.

Frédéric THOMAS


----------------------------------------
> From: aharui@adobe.com
> To: dev@flex.apache.org
> Subject: Re: [FalconJX] Code formatting
> Date: Mon, 29 Jun 2015 14:19:35 +0000
>
>
>
> On 6/28/15, 3:18 PM, "Michael Schmalle" <teotigraphixllc@gmail.com> wrote:
>
>
>>If nobody objects after 3 days I am running it on the whole compiler.jx
>>and
>>tests projects to get all formatting back in sync. It's driving me crazy
>>committing things that are 2 lines but my formatter is formatting a lot
>>more.
>
> No real objections here. I’m not a huge fan of automatic line-length
> requirements. To me, there is some art to formatting code. I remember
> trying to use it but it was hard to remember to use since it wasn’t
> “automatic”, but I’ll try to get in the habit.
>
> IIRC, Gordon found that it screwed up some code. Is it possible that the
> formatter has bugs?
>
> -Alex
>
>
 		 	   		  
Mime
View raw message