Mailing-List: contact dev-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flex.apache.org
From: Harbs <harbs.lists@gmail.com>
Content-Type: multipart/alternative;
 boundary="Apple-Mail=_D218CC3B-CFDE-45F1-81AB-36C53FAFE4FC"
Message-Id: <0E0AD554-D682-40ED-AC1D-316337EA9ED5@gmail.com>
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Subject: Re: Squiggly Oddness
Date: Wed, 27 May 2015 19:20:02 +0300
References: <D4F51E81-9512-437A-84D8-60239B0D1BDA@gmail.com>
 <66D26846-0B2F-45A0-A41F-3498C2E6CDB8@gmail.com>
 <D18B284B.314D5%aharui@adobe.com>
To: dev@flex.apache.org
In-Reply-To: <D18B284B.314D5%aharui@adobe.com>

--Apple-Mail=_D218CC3B-CFDE-45F1-81AB-36C53FAFE4FC
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=windows-1252

FWIW, I solved my specific issue by using an index instead of a =
reference to the controller, and I always resolve the controller using =
flowComposer.getControllerAt(_flowIndex);

As for the why:
Squiggly replaces the standard ContainerController with a =
SquigglyCustomContainerController (which extends ContainerController) =
with a signature like this:
		public function =
SquigglyCustomContainerController(container:Sprite,textHighlighter:IHighli=
ghter, wordProcessor:IWordProcessor, engine:SpellingService,
										=
				  func:Function, =
compositionWidth:Number=3D100,compositionHeight:Number=3D100)

I believe the primary reason is to support the context menu.

I was thinking about this some more, and I=92m thinking that there =
should be an ISpellingController and Squiggly should only replace the =
controller if the existing controller is not a ISpellingController. That =
would allow clients to add their own ISpellingControllers which would =
not be replaced.

If there=92s some way to inject the context menu and take care of the =
other four components (IHighlighter, IWordProcessor, SpellingService and =
the ignoreWordFunctionProcessor), that might be best.

On May 27, 2015, at 5:54 PM, Alex Harui <aharui@adobe.com> wrote:

> I haven=92t looked at the code at all, but maybe it would be worth =
trying to
> figure out =93why=94 Squiggly replaces the controller.  I would =
imagine it is
> to get certain events so it knows when to run its spell checker and/or
> injecting the squiggly decoration.  Having the controller dispatch the
> right events and providing a hook to inject decorations might be a =
better
> approach so Squiggly doesn=92t have to be so invasive.
>=20
> -Alex
>=20
> On 5/27/15, 3:23 AM, "Harbs" <harbs.lists@gmail.com> wrote:
>=20
>> One idea which could solve problem #1 would be to add a method
>> IFlowComposer.replaceController() which would dispatch an event with =
the
>> old controller and the new one.
>>=20
>> But, this doe not solve problem #2. There must be some way of solving
>> this using composition=85
>>=20
>> On May 27, 2015, at 1:18 PM, Harbs <harbs.lists@gmail.com> wrote:
>>=20
>>> When loading Squiggly, it modifies the controllers in the =
FlowComposer
>>> and swaps out the existing controllers with
>>> SquigglyCustomContainerControllers.
>>>=20
>>> This is problematic:
>>> 1) There=92s no way to track ContainerControllers while using =
Squiggly.
>>> Any tracked ContainerControllers become unused. (I currently have =
this
>>> problem. I have some code which tracks threading across containers.)
>>> 2) If someone subclasses ContainerController for some reason, their
>>> code blows up.
>>>=20
>>> Any suggestions on how to solve this problem?
>>>=20
>>> Harbs
>>=20
>=20


--Apple-Mail=_D218CC3B-CFDE-45F1-81AB-36C53FAFE4FC--