flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - Revert "Revert "SCRIPT_HOME path had extra slash""
Date Thu, 14 May 2015 06:41:20 GMT
Hi Kevin,

Yes, shell scripts are a whole different language.  I’m no expert either.

I think there is a fourth scenario, where FALCON_HOME is set to a folder
in a flex-falcon repo, so I’m not sure you can use FALCON_HOME instead of
SCRIPT_HOME.

To me, the issue appears to be this portion of the script:

if [ "x${FALCON_HOME}" = "x" ]
then
    SCRIPT_HOME=`dirname $0`
    FALCON_HOME=${SCRIPT_HOME}/../..
fi

I think this might need to have SCRIPT_HOME taken out of the if/then and
run earlier.  Because if FALCON_HOME is set, then SCRIPT_HOME never gets
set


Thanks,
-Alex

On 5/13/15, 8:43 PM, "kevin.godell" <kevin.godell@gmail.com> wrote:

>I tried to post earlier, but it seems to have been lost. Hopefully this
>will
>not be a double post.
>
>Leaving the mxmlc as it was before the patch, this was my results calling
>it
>from command line taking intellij out of the picture for the moment.
>
>env var FLEX_HOME and FALCON_HOME set to
>/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/
>
>Kevins-MBP:~ kevinGodell$
>/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/js/bin/mxmlc
>/Users/kevinGodell/IdeaProjects/flexJS/DataBindingTest/src/DataBindingTest
>.mxml
>Using Falcon codebase:
>/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/
>Using Flex SDK: /Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/
>Error: Unable to access jarfile /../lib/mxmlc.jar
>
>env var FLEX_HOME and FALCON_HOME set to
>/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17
>
>Kevins-MBP:~ kevinGodell$
>/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/js/bin/mxmlc
>/Users/kevinGodell/IdeaProjects/flexJS/DataBindingTest/src/DataBindingTest
>.mxml
>Using Falcon codebase:
>/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17
>Using Flex SDK: /Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17
>Error: Unable to access jarfile /../lib/mxmlc.jar
>
>unset FLEX_HOME and FALCON_HOME
>
>Kevins-MBP:~ kevinGodell$
>/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/js/bin/mxmlc
>/Users/kevinGodell/IdeaProjects/flexJS/DataBindingTest/src/DataBindingTest
>.mxml
>Using Falcon codebase:
>/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/js/bin/../..
>Using Flex SDK:
>/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/js/bin/../..
>Compiling file:
>/Users/kevinGodell/IdeaProjects/flexJS/DataBindingTest/bin/js-debug/DataBi
>ndingTest.js
>…and then it completes
>
>Later I edited the mxmlc and changed the mxmlc.jar reference to -jar
>"$FALCON_HOME/js/lib/mxmlc.jar" . This satisfied all 3 situations tested:
>no
>env vars, vars set with trailing slash, and then without trailing slash. I
>dont know if this covers every possible scenario. And just for the
>record, I
>had to read some tuts just to understand the basic structure of shell
>scripting, so don't trust it on my word alone.
>
>
>
>--
>View this message in context:
>http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-fle
>x-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-t
>p46455p46493.html
>Sent from the Apache Flex Development mailing list archive at Nabble.com.

Mime
View raw message