flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From OmPrakash Muppirala <bigosma...@gmail.com>
Subject Re: [2/3] git commit: [flex-sdk] [refs/heads/develop] - Compiler: fixed issue where adding an id to a fx:Vector when using -keep compiler argument would result in a compiler error because the wrong class was imported in the generated code for the bindable p
Date Tue, 26 May 2015 23:21:06 GMT
On Tue, May 26, 2015 at 4:14 PM, Josh Tynjala <joshtynjala@gmail.com> wrote:

> I found these bugs while working on the Feathers SDK (it's my fork of the
> Apache Flex SDK for Feathers and Starling), and I figured that I'd push the
> fixes upstream since they reproduce with Apache Flex too.
>
> Should I create JIRAs with the appropriate details and then close them as
> fixed?
>

Yes, please.  This makes things so much more easier during release time.
Also, a reference to the corresponding commit (ex. Commit:
http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/ab273645) in the
JIRA ticket as a comment when closing the ticket would be great as well.

Thanks,
Om


>
> - Josh
>
> On Tue, May 26, 2015 at 4:05 PM, Justin Mclean <justinmclean@me.com>
> wrote:
>
> > Hi,
> >
> > Thanks for the fixes. Were JIRAs raised for these or do they relate to a
> > raised JIRA? The release notes are generally built up from information in
> > JIRA so it good to have it documented there.
> >
> > Thanks,
> > Justin
> >
> > > On 27 May 2015, at 8:17 am, joshtynjala@apache.org wrote:
> > >
> > > Compiler: fixed issue where adding an id to a fx:Vector when using
> -keep
> > compiler argument would result in a compiler error because the wrong
> class
> > was imported in the generated code for the bindable property.
> > >
> > > getMultiName() in flex2.compiler.as3.binding.Info wasn't treating
> > __AS3__.vec.Vector.<T> the same as __AS3__.vec:Vector.<T>, causing it
to
> > return the wrong namespace and class name.
> > >
> > >
> > > Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
> > > Commit:
> http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/ab273645
> > > Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/ab273645
> > > Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/ab273645
> > >
> > > Branch: refs/heads/develop
> > > Commit: ab27364581abb4476132ef2b1cdbcb90d2514331
> > > Parents: ffdb071
> > > Author: Josh Tynjala <joshtynjala@apache.org>
> > > Authored: Tue May 26 15:14:53 2015 -0700
> > > Committer: Josh Tynjala <joshtynjala@apache.org>
> > > Committed: Tue May 26 15:14:53 2015 -0700
> > >
> > > ----------------------------------------------------------------------
> > > .../src/java/flex2/compiler/as3/binding/Info.java        | 11
> ++++++++++-
> > > 1 file changed, 10 insertions(+), 1 deletion(-)
> > > ----------------------------------------------------------------------
> > >
> > >
> > >
> >
> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/ab273645/modules/compiler/src/java/flex2/compiler/as3/binding/Info.java
> > > ----------------------------------------------------------------------
> > > diff --git
> > a/modules/compiler/src/java/flex2/compiler/as3/binding/Info.java
> > b/modules/compiler/src/java/flex2/compiler/as3/binding/Info.java
> > > index 73ccbdd..f8b4fac 100644
> > > --- a/modules/compiler/src/java/flex2/compiler/as3/binding/Info.java
> > > +++ b/modules/compiler/src/java/flex2/compiler/as3/binding/Info.java
> > > @@ -262,7 +262,16 @@ abstract class Info
> > >
> > >         if (lastIndex < 0)
> > >         {
> > > -            lastIndex = name.lastIndexOf(".");
> > > +            // check for __AS3__.vec.Vector.<T>
> > > +            int dotLessThanIndex = name.lastIndexOf(".<");
> > > +            if (dotLessThanIndex != -1)
> > > +            {
> > > +                lastIndex = name.lastIndexOf(".", dotLessThanIndex -
> 1);
> > > +            }
> > > +            else
> > > +            {
> > > +                lastIndex = name.lastIndexOf(".");
> > > +            }
> > >         }
> > >
> > >         if (lastIndex > 0)
> > >
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message