flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mihai Chira <mihai.ch...@gmail.com>
Subject Re: [1/2] git commit: [flex-tlf] [refs/heads/develop] - FLEX-34756 Split the functionality provided by FlowComposerBase.isDamaged() and StandardFlowComposer.isDamaged() into two separate functions, because 1) they do very different things, and 2) to solve FL
Date Thu, 16 Apr 2015 07:49:55 GMT
Great, thanks for that.

I guess the numbers you changed in those tests are now what they
should be, rather than what they need to be for the tests to pass,
right?

On 13 April 2015 at 06:31, piotrz <piotrzarzycki21@gmail.com> wrote:
> Mihai,
>
> Let's leave it as it is. I have just fixed these tests and now our branch
> should back to the normal state.
>
> UnitTest.Tests::KeyboardGestureTest.pgUpLocationTest
> UnitTest.Tests::KeyboardGestureTest.pgUpLanguageTest
> UnitTest.Tests::KeyboardGestureTest.shiftPgUpGeneralTest
> UnitTest.Tests::KeyboardGestureTest.shiftPageUpLocationTest
> UnitTest.Tests::KeyboardGestureTest.shiftPageUpLanguageTest
>
> I am not sure whether this is a good fix but will see. - Maybe someone will
> say -1 for this commit. ;)
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-1-2-git-commit-flex-tlf-refs-heads-develop-FLEX-34756-Split-the-functionality-provided-by-FlowComL-tp45873p46057.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.

Mime
View raw message