Mailing-List: contact dev-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flex.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Reply-To: <lists@cranialinteractive.com>
From: "Neil Madsen" <lists@cranialinteractive.com>
To: <dev@flex.apache.org>
References: 
 <CAJs+wW0y3xFhQWa5R9_F8SNaEFbu9r6XHgG0Wxv6R4UKum=pdg@mail.gmail.com>
 <1423123065913-44957.post@n4.nabble.com>
 <5B9E81939A09494CA8DBEFC93C11F7D1@NeilXPS9000>
 <D0F8D777.25703%aharui@adobe.com>
In-Reply-To: <D0F8D777.25703%aharui@adobe.com>
Subject: RE: [DISCUSS] Release Apache Flex SDK Installer 3.2
Date: Thu, 5 Feb 2015 09:50:18 -0700
Organization: Cranial Interactive
Message-ID: <23D4D2F8368842C6ACB895FB0FFD48E1@NeilXPS9000>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: AQHQPw1RT1JSe6yklk6bgX062DXoVZzhtL+AgACH9wD//38BAIAAimXA

Hi Alex,
Yes, this is exactly what is happening. When the language changes it doesn't
check if there is data from the XML file available. It simply rebuilds the
list of items from a predefined set in this method
"initializeInstallerComponentsDataProvider()". It should be looking for any
data stored in "_installerComponentsDataProvider" and use that data if it's
there. 

What I think has happened is that when the code was added to load the XML
config data, the installer wasn't updated to use that data in all scenarios
(and there are more than a few now). 

I think I know what needs to happen now so I'll try to wire it all up and
get a working version. If I have any troubles I'll be sure to ask on the
list. I'm pretty sure the "_installerComponentsDataProvider" and the
"usingXML:Boolean" need to be used within the
"initializeInstallerComponentsDataProvider()" method to determine what
components/checkboxes are supposed to be displayed. This will allow for the
dynamic data and a fallback for versions not using the XML config data.

I'll post back with my results.

Neil  

-----Original Message-----
From: Alex Harui [mailto:aharui@adobe.com] 
Sent: February-05-15 9:23 AM
To: dev@flex.apache.org; Neil Madsen
Subject: Re: [DISCUSS] Release Apache Flex SDK Installer 3.2

Hi Neil,

It sounds like there may still be confusion about how the checkbox set is
determined.  For recent releases like Flex SDK 4.13 and 4.14, and for FlexJS
releases, the 'final' list of items is not in the InstallApacheFlex.mxml
file at all.  Really, there is no final list.  It is totally data driven
from xml files co-located with the release artifacts and can be different
for each release.  We can even change an .xml file after we release and the
Installer needs to pick up that change at runtime.  There is a set of
checkboxes in InstallApacheFlex.mxml, but that is used for Flex SDK 4.12.1
and older (actually even whether 4.12.x uses the built-in checkboxes is
determined by another .xml file).

IOW, we are trying to make the installer be totally data driven, but it has
to keep an old code path around.  It looks like when the language changes,
the installer reverts to the old code path.  It needs to go down the new
code path with the new language.

HTH,
-Alex


On 2/5/15, 8:04 AM, "Neil Madsen" <lists@cranialinteractive.com> wrote:

>I have made some changes to the code and the check boxes seem to be 
>working.
>If I could get a 'final' list of items to be displayed I can make sure 
>the correct items are being displayed and then push this version for
testing.
>
>Neil
>
>
>-----Original Message-----
>Subject: Re: [DISCUSS] Release Apache Flex SDK Installer 3.2
>
>Thanks Piotr. I see what's happening.
>Can someone please give a list of all required/optional check boxes to 
>be displayed for v4.14.0
>
>There has been so much discussion regarding what should and shouldn't 
>be required I lost track and I'm not sure where it stands right now. If 
>I have a list I can fix up the error when changing languages on the 
>license screen.
>
>
>Neil
>
>
>-----Original Message-----
>From: piotrz [mailto:piotrzarzycki21@gmail.com]
>Sent: February-05-15 12:58 AM
>To: dev@flex.apache.org
>Subject: Re: [DISCUSS] Release Apache Flex SDK Installer 3.2
>
>Hi,
>
>I've just tried last nightly build of installer (Build #380) and on the 
>license agreements I see:
>
>http://images.devs-on.net/Image/a1bcfrLefuRiHbJB-Obszar.png
>
>Once I change language I see:
>
>http://images.devs-on.net/Image/qJZ5xeUiPfgyTChe-Obszar.png
>
>So we have an issue here. Additionally I don't see this ->
>https://issues.apache.org/jira/browse/FLEX-34687
>
>Piotr
>
>
>-----
>Apache Flex PMC
>piotrzarzycki21@gmail.com
>--
>View this message in context:
>http://apache-flex-development.2333347.n4.nabble.com/DISCUSS-Release-Ap
>ach
>e-
>Flex-SDK-Installer-3-2-tp44853p44957.html
>Sent from the Apache Flex Development mailing list archive at Nabble.com.
>