flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject Re: BorderColor for TextInput in new mobile skins
Date Thu, 12 Feb 2015 23:36:40 GMT
What is the simplest test case for reproducing this problem?

If you are using FB, did you restart FB?  Otherwise it might be using
cached SWCs.

-Alex

On 2/12/15, 3:30 PM, "OmPrakash Muppirala" <bigosmallm@gmail.com> wrote:

>It looks like the 'mobile' theme is different from the 'spark' theme.  So,
>I changed
>
>spark/src/spark/components/supportClasses/SkinnableTextBase.as:
>
>[Style(name="borderColor", type="uint", format="Color", inherit="no",
>theme="spark")]
>
>to
>
>[Style(name="borderColor", type="uint", format="Color", inherit="no",
>theme="spark, mobile")]
>
>This still does not get rid of the warnings.
>
>Thanks,
>Om
>
>On Thu, Feb 12, 2015 at 2:29 PM, OmPrakash Muppirala
><bigosmallm@gmail.com>
>wrote:
>
>> On Thu, Feb 12, 2015 at 2:23 PM, Alex Harui <aharui@adobe.com> wrote:
>>
>>> The metadata on components like this one setup what the compiler cares
>>> about:
>>>
>>>
>>> 
>>>spark/src/spark/components/supportClasses/SkinnableTextBase.as:[Style(na
>>>me=
>>> "borderColor", type="uint", format="Color", inherit="no",
>>>theme="spark")]
>>>
>>>
>>>
>>> Do use the iOS and Android skins, do you change certain compiler
>>>options?
>>>
>>
>> No, no compiler options are required to use them.  Something like that
>>is
>> required only to see the appropriate skins on the AIR simulator [1]
>>
>> Thanks,
>> Om
>>
>> [1]
>> 
>>https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=50856172
>>
>>
>>
>>>
>>> -Alex
>>>
>>> On 2/12/15, 2:17 PM, "OmPrakash Muppirala" <bigosmallm@gmail.com>
>>>wrote:
>>>
>>> >I am guessing that the warning messages are hardcoded somewhere.  I
>>>don't
>>> >see any reason it should think it not a spark skin.
>>> >
>>> >Thanks,
>>> >Om
>>> >
>>> >On Thu, Feb 12, 2015 at 2:14 PM, Alex Harui <aharui@adobe.com> wrote:
>>> >
>>> >> Probably need to look into it in the compiler.  It thinks the theme
>>>is
>>> >>no
>>> >> longer Spark.  Why would that be the case?
>>> >>
>>> >> -Alex
>>> >>
>>> >> On 2/12/15, 2:09 PM, "OmPrakash Muppirala" <bigosmallm@gmail.com>
>>> wrote:
>>> >>
>>> >> >(Moving discussion to @dev)
>>> >> >
>>> >> >Actually, we do support borderColor in the new iOS and Android
>>>skins.
>>> >>I
>>> >> >am
>>> >> >not sure how to remove the warnings in this case.
>>> >> >
>>> >> >A less elegant solution would be to give it a different name.
>>> >> >
>>> >> >Thoughts?
>>> >> >
>>> >> >Thanks,
>>> >> >Om
>>> >> >
>>> >> >On Thu, Feb 12, 2015 at 2:00 PM, Piotr Zarzycki (JIRA)
>>> >><jira@apache.org>
>>> >> >wrote:
>>> >> >
>>> >> >>
>>> >> >>      [
>>> >> >>
>>> >>
>>> >>>>
>>> https://issues.apache.org/jira/browse/FLEX-34732?page=com.atlassian.jir
>>> >>>>a
>>> >> .
>>> >> >>plugin.system.issuetabpanels:all-tabpanel
>>> >> >> ]
>>> >> >>
>>> >> >> Piotr Zarzycki mentioned you on FLEX-34732
>>> >> >> ----------------------------------
>>> >> >>
>>> >> >> It's even worst because once I apply borderColor for TextInput
in
>>> >>mobile
>>> >> >> project I got an error:
>>> >> >>
>>> >> >> The style 'borderColor' is only supported by type
>>> >> >> 'spark.components.TextInput' with the theme(s) 'spark'.
>>> >> >>
>>> >> >> [~bigosmallm] what do you think - Shouldn't we remove borderColor
>>> >>from
>>> >> >> defaults.css for TextInput and applied these color in a different
>>> >>way ?
>>> >> >>
>>> >> >> >                 Key: FLEX-34732
>>> >> >>
>>> >> >> >         View Online:
>>> >>https://issues.apache.org/jira/browse/FLEX-34732
>>> >> >> >         Add Comment:
>>> >> >> https://issues.apache.org/jira/browse/FLEX-34732#add-comment
>>> >> >>
>>> >> >> Hint: You can mention someone in an issue description or comment
>>>by
>>> >> >> typing  "@" in front of their username.
>>> >> >>
>>> >> >>
>>> >> >>
>>> >> >>
>>> >> >> --
>>> >> >> This message was sent by Atlassian JIRA
>>> >> >> (v6.3.4#6332)
>>> >> >>
>>> >>
>>> >>
>>>
>>>
>>

Mime
View raw message