Return-Path: X-Original-To: apmail-flex-dev-archive@www.apache.org Delivered-To: apmail-flex-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EC7AF175B4 for ; Thu, 6 Nov 2014 19:32:17 +0000 (UTC) Received: (qmail 68718 invoked by uid 500); 6 Nov 2014 19:32:15 -0000 Delivered-To: apmail-flex-dev-archive@flex.apache.org Received: (qmail 68664 invoked by uid 500); 6 Nov 2014 19:32:15 -0000 Mailing-List: contact dev-help@flex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flex.apache.org Delivered-To: mailing list dev@flex.apache.org Received: (qmail 67619 invoked by uid 99); 6 Nov 2014 19:32:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Nov 2014 19:32:14 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of harbs.lists@gmail.com designates 209.85.212.179 as permitted sender) Received: from [209.85.212.179] (HELO mail-wi0-f179.google.com) (209.85.212.179) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Nov 2014 19:31:47 +0000 Received: by mail-wi0-f179.google.com with SMTP id h11so2522711wiw.12 for ; Thu, 06 Nov 2014 11:31:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date :content-transfer-encoding:message-id:references:to; bh=qG+rX1hBZvKTRnmUf70N/qRh91ff1cU/OHuBBJbms0M=; b=x06krIHNlBCp4F7+DzaRkjYtolHXYsSJM4MZhPeJknRwlCHTOlPGgjun2CWR3ekES+ O2Qyekh0oSMx+Lq0C2fvYwcli+xzDgyNV5Wb6nUfTR2vo0YLqd6p/7RKqtn4cyMApQsX qIfCn5gayLgdSr4Z18ZFrh8xS8Y7TeVGS1ftzt8pk3sFSKziOK/kgDGhylFOUFFMqZp+ mt0VbGlq3bMoZzw9pS+HrmkiOMkKMACOM8WOOpS8784UyKif/MqGki8q/sgXBxBt6dpT oe3z+V/CX5FImxf9kZ3e9qoFiOGYahKuZLGAMWXNVEGKBFzbNvyXj6e7EBRZwmhz51XQ TSPg== X-Received: by 10.194.58.205 with SMTP id t13mr8513505wjq.55.1415302306465; Thu, 06 Nov 2014 11:31:46 -0800 (PST) Received: from [192.168.0.5] ([37.46.36.99]) by mx.google.com with ESMTPSA id wl1sm9004467wjb.4.2014.11.06.11.31.44 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 06 Nov 2014 11:31:45 -0800 (PST) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: TextFlowLine recycling From: Harbs In-Reply-To: Date: Thu, 6 Nov 2014 21:31:40 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <7BB1BB3E-7106-4016-A47B-960272858D35@gmail.com> References: To: dev@flex.apache.org X-Mailer: Apple Mail (2.1878.6) X-Virus-Checked: Checked by ClamAV on apache.org If someone has the time to walk through this with me off-list, that = would be very helpful. I=92d really like an extra set of eyeballs to = make sure I=92m not missing something with this and I don=92t blow = things up. I don=92t have a good enough grasp on exactly how the = management of TextFlowLines is supposed to be working. On Nov 6, 2014, at 7:15 PM, Alex Harui wrote: > My memory is a bit fuzzy. I thought TextLine recycling wasn=92t > per-paragraph, or is there a TextBlock per paragraph? >=20 > The doc says that TextBlock.createTextLine/recreateTextLine returns = null > if the TextBlock is empty or if the width specified is less than the = width > of the next element, and to check the TextBlock.textLineCreationResult > property if you get a null. >=20 > Could it just be that the number of lines in the paragraph when to = zero? >=20 > -Alex >=20 > On 11/6/14, 2:26 AM, "Harbs" wrote: >=20 >> I ran into an issue where I have a runtime error in >> TextFlowLine.getTextLine(). I=92m having trouble stepping through = things, >> but as best as I can figure, the issue is caused by the umber of = lines in >> a paragraph becoming reduced. >>=20 >> The RTE happens inside TextFlowline.recreateTextLine() after = requesting >> the line from the TextBlock. The function (I=92m not sure if it=92s >> createTextLine or recreateTextLine) returns null. The = TextBlock.lastLine >> is the line before the current one. >>=20 >> The caller of this mess is ComposeState.composeNextLine. >>=20 >> If anyone is still following me, my problem is I=92m not sure the = best way >> to fix this. I=92m not sure why this is breaking now. I=92m not sure = what I >> changed that=92s causing this error. Should I fix >> TextFlowLine.getTextLine() to return null if there=92s no more lines = in the >> paragraph? Will there be any other repercussions from doing that? = Should >> I fix ComposeState/BaseCompose so it does not try to compose the = next >> line once the paragraph is out of lines? >>=20 >> Is anyone familiar enough with the composer to even give me = suggestions? >> :-( >>=20 >> Harbs >=20