flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Harbs <harbs.li...@gmail.com>
Subject Re: Commit of table work
Date Mon, 06 Oct 2014 06:15:12 GMT
I’m not sure. I will personally be using the code in production by then. I’d love to have
unit tests and the like working, but I’m not sure what’s involved in that. (I need help
with unit tests.)

I’ve “touched” an incredible amount of TLF code and this stuff is unbelievably fragile.
Tiny little issues have caused me to spend literally days tracking down what was going wrong.
The way I’ve implemented the tables, they are a bit of a special case, and need to be handled
as such in quite a few places.

One small example: I implemented “TableLeafElement” which is completely virtual to satisfy
assumptions made all over the place which separates the concept of leaf elements and group
elements. Just this morning I discovered a case where ParaEdit makes assumptions about Elements
that does not work with TableLeafElement. I’m in middle of editing TableLeafElement to satisfy
that case.

So in short: If I get help with the unit testing, probably. If not, probably not…

On Oct 6, 2014, at 9:04 AM, Erik de Bruin <erik@ixsoftware.nl> wrote:

> Thank you Harbs!
> 
> If we release 4.14 in a “few” weeks, do you think the tables work will be
> in such a shape that we can ship it?
> 
> EdB
> 
> 
> 
> On Mon, Oct 6, 2014 at 6:15 AM, Alex Harui <aharui@adobe.com> wrote:
> 
>> Awesome!
>> 
>> On 10/5/14, 12:57 PM, "Harbs" <harbs.lists@gmail.com> wrote:
>> 
>>> One more thing:
>>> 
>>> I¹m pretty sure there were changes done to TLF in develop after I forked
>>> the code, so this changes will need to be merged in.
>>> 
>>> On Oct 5, 2014, at 10:53 PM, Harbs <harbs.lists@gmail.com> wrote:
>>> 
>>>> I just committed my work on tables to the repository. I committed it to
>>>> a new branch called tables. There¹s still work to be done before it can
>>>> be merged with develop. Here¹s a summary of the status:
>>>> 
>>>> 1) There are NO unit tests. I have not run any existing test nor have I
>>>> created any new tests. I have zero experience with tests. I¹ll be happy
>>>> to do some work on this, but I will need direction.
>>>> 2) Markup will probably not work. All my testing with the code has been
>>>> creating elements directly.
>>>> 3) There are no Operations that currently work correctly with tables,
>>>> so Undo with tables is a no-no.
>>>> 4) I have made changes to SelectionManager, and there¹s now a concept
>>>> of nested TextFlows and nested SelectionManagers/EditManagers. Text in
>>>> table cells are nested TextFlows rather than children of the main
>>>> TextFlow.
>>>> 5) ParagraphElements can now contain more than a single TextBlock.
>>>> Substantial work has been done to support this.
>>>> 
>>>> A quick summery of what features are supported:
>>>> 
>>>> 1) While it¹s possible to specify header and footer cells, they are
>>>> ineffectual.
>>>> 2) Cells spanning columns work, but ones spanning rows do not.
>>>> 3) Multiple cells can be selected, but the must be contiguous ranges.
>>>> 4) It¹s possible to get the selection of cells from the parent
>>>> EditManager.
>>>> 5) All basic cell formatting is supported (strokes, fills, inset, etc.)
>>>> 6) No stroke/fil patterns are supported. If you need alternating fills
>>>> for example, they must be specified directly.
>>>> 7) Fixed height and expanding height cells are supported. All cells
>>>> must have a fixed width.
>>>> 
>>>> That¹s more or less what comes to mind right now. I will be committing
>>>> any fixes to the tables branch from now on. I¹ll try to document as much
>>>> as I can somewhereŠ ;-)
>>>> 
>>>> Harbs
>>> 
>> 
>> 
> 
> 
> -- 
> Ix Multimedia Software
> 
> Jan Luykenstraat 27
> 3521 VB Utrecht
> 
> T. 06-51952295
> I. www.ixsoftware.nl


Mime
View raw message