Mailing-List: contact dev-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flex.apache.org
From: Tom Chiverton <tomc@apache.org>
To: dev@flex.apache.org
Subject: Re: EmailValidator sdk 4.13
Date: Tue, 05 Aug 2014 22:50:43 +0100
Message-ID: <4203825.kbyDuyTO28@wopr.house>
Organization: Apache Flex
User-Agent: KMail/4.13.3 (Linux/3.13.0-32-generic; KDE/4.13.3; i686; ; )
In-Reply-To: 
 <CACK5iZc_BwJws2Z+8PU3p6tc+dRJPq-2WSNLrEQa125zhUrMeA@mail.gmail.com>
References: <1406027265738-39263.post@n4.nabble.com>
 <9844082.B0D1sdtil2@wopr.house>
 <CACK5iZc_BwJws2Z+8PU3p6tc+dRJPq-2WSNLrEQa125zhUrMeA@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Tuesday 05 Aug 2014 14:36:38 OmPrakash Muppirala wrote:
> for folks to contribute.  Please let us know your thoughts on this as
> well.

I've learnt two things
1) In general, make sure you check the Jenkins Mustella run the day after a checkin. I put the URL on the Wiki just now as I couldn't find it at work today !
2) Specifically, a lot of the unit tests for LangPacks strike me as redundant, they just repeat the same test case in each language and check the string from the translation appears. Surely the fact that string bundles are localised is checked at a lower level, so many of these could be removed ? This would make changing Validators specifically and language strings in general less work.

-- 
Tom