flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject Re: [JIRA](ISSUE #FLEX-34119) Dev review request
Date Tue, 22 Jul 2014 16:49:17 GMT
Hi Mihai,

Thanks for taking on such a challenging goal.

I don't see anything obviously wrong.  IMO, the best thing to do would be
to set up mustella and run the Advanced DataGrid tests.  That's what our
CI system will do when you finally check this into the develop branch.

It is a bit puzzling that the old code messed around with the parent stack
and it looks like you no longer need to.  I wonder if there is some edge
case associated with that.

-Alex

On 7/22/14 4:00 AM, "Mihai Chira" <mihai.chira@gmail.com> wrote:

>On the branch "FLEX-34119" I committed two unit tests and a fix for
>this bug. If anyone would like to take a look, and run the tests, it
>would be really helpful, because it's a trickier area of the SDK.
>Could you let me know if:
>* you think the unit tests are in the right folder
>* the unit tests run as expected (see the README in
>HierarchicalCollectionViewCursor_FLEX_34119_Test for some explanations
>about it)
>* it looks like the commits might break anything else
>* you think the variable renames in HierarchicalCollectionViewCursor are
>helpful
>* we could run the unit tests automatically on each ant build. Is that
>possible now?
>
>I'm still adding an operation to the unit test (setItemAt), and
>looking to remove some duplicated code from
>HierarchicalCollectionViewCursor.collectionChangeHandler.
>I also plan to run the mustella tests soon, to make sure I haven't
>broken anything.
>
>
>Thank you!
>Mihai


Mime
View raw message