flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erik de Bruin <e...@ixsoftware.nl>
Subject Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34222 fix selection reverting to previous typed values when second value (not in list) is entered
Date Thu, 05 Jun 2014 07:56:18 GMT
-1 (binding)

I'm vetoing this commit because it is causing the following (sets of)
Mustella tests to fail:

- gumbo/components/ComboBox/Properties/ComboBox_Properties_UserInput
(aharui: "The ComboBox failures are due to the change FLEX-34222. I have
not looked into why.")

It has been three weeks without a working solution (or 'fix' of the tests)
and we need the successful Mustella runs because we're looking to get out a
new release, so: please revert - or fix - this commit and all related ones.

Thanks,

EdB



On Sun, May 18, 2014 at 8:33 PM, <jmclean@apache.org> wrote:

> Repository: flex-sdk
> Updated Branches:
>   refs/heads/develop 8d030e703 -> 05ea4798b
>
>
> FLEX-34222 fix selection reverting to previous typed values when second
> value (not in list) is entered
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/05ea4798
> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/05ea4798
> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/05ea4798
>
> Branch: refs/heads/develop
> Commit: 05ea4798b51a03ef94576f17512473296a5d42a1
> Parents: 8d030e7
> Author: Justin Mclean <jmclean@apache.org>
> Authored: Sun May 18 11:33:13 2014 -0700
> Committer: Justin Mclean <jmclean@apache.org>
> Committed: Sun May 18 11:33:13 2014 -0700
>
> ----------------------------------------------------------------------
>  frameworks/projects/spark/src/spark/components/ComboBox.as | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/05ea4798/frameworks/projects/spark/src/spark/components/ComboBox.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/spark/src/spark/components/ComboBox.as
> b/frameworks/projects/spark/src/spark/components/ComboBox.as
> index 6ef3125..9be4b50 100644
> --- a/frameworks/projects/spark/src/spark/components/ComboBox.as
> +++ b/frameworks/projects/spark/src/spark/components/ComboBox.as
> @@ -672,6 +672,7 @@ public class ComboBox extends DropDownListBase
> implements IIMESupport
>              }
>              else
>              {
> +                               selectedItem = textInput.text;
>                  super.changeHighlightedSelection(CUSTOM_SELECTED_ITEM);
>              }
>          }
> @@ -980,7 +981,7 @@ public class ComboBox extends DropDownListBase
> implements IIMESupport
>                  if (selectedItem != null)
>                      textInput.text = itemToLabel(selectedItem);
>                  else
> -                textInput.text = "";
> +                       textInput.text = "";
>              }
>              changeHighlightedSelection(selectedIndex);
>          }
>
>


-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message