Return-Path: X-Original-To: apmail-flex-dev-archive@www.apache.org Delivered-To: apmail-flex-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6E8FE1096B for ; Mon, 27 Jan 2014 22:31:54 +0000 (UTC) Received: (qmail 7590 invoked by uid 500); 27 Jan 2014 22:31:53 -0000 Delivered-To: apmail-flex-dev-archive@flex.apache.org Received: (qmail 7559 invoked by uid 500); 27 Jan 2014 22:31:53 -0000 Mailing-List: contact dev-help@flex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flex.apache.org Delivered-To: mailing list dev@flex.apache.org Received: (qmail 7551 invoked by uid 99); 27 Jan 2014 22:31:53 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jan 2014 22:31:53 +0000 X-ASF-Spam-Status: No, hits=1.7 required=5.0 tests=FREEMAIL_ENVFROM_END_DIGIT,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of omuppi1@gmail.com designates 209.85.212.48 as permitted sender) Received: from [209.85.212.48] (HELO mail-vb0-f48.google.com) (209.85.212.48) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jan 2014 22:31:48 +0000 Received: by mail-vb0-f48.google.com with SMTP id q16so3772908vbe.21 for ; Mon, 27 Jan 2014 14:31:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:content-type; bh=pzrzaV9TEaG6RWWSvbj7Sny7/05scRYlSaaQk4jXb/s=; b=HJdgz0D3R8CIdGEAFvPchJdP3+/EPeSS6YV53ZfkxxlTC1Fn4uuZY8EgIcMVPCp17x KA6QEmgihe+0yF1+ahBO6j2L1Poc561TCK6xE2ymHK3GBQ9q/h++1VEHoYfZn00QXraO oUDPbipt3ns7W6U1hgjTilOvoxXXzHs9BUZu2fDkJF5u48Ivz9Q35tnGOAa9hR13S2De Lzq3lzvhFeGxfAkZj0SiDT9Q/BAsnNNQ3rOVwMwWKQWTLjBmIBxi9hgy/hwZ8Ta9sVHK JaWS00Z3KcLoTSSH2OTlj0u/DwC7ogMvnXMTuAHJcac2jKn+44lJJkRLd3lB3mtfb23u Elqg== X-Received: by 10.58.117.65 with SMTP id kc1mr97531veb.68.1390861887508; Mon, 27 Jan 2014 14:31:27 -0800 (PST) MIME-Version: 1.0 Sender: omuppi1@gmail.com Received: by 10.58.232.138 with HTTP; Mon, 27 Jan 2014 14:30:57 -0800 (PST) In-Reply-To: References: From: OmPrakash Muppirala Date: Mon, 27 Jan 2014 14:30:57 -0800 X-Google-Sender-Auth: LZ3JVTNu7JcEAgH_rjTKVSPC4hI Message-ID: Subject: Re: [Installer] Replacing RuntimeLocale.as To: "dev@flex.apache.org" Content-Type: multipart/alternative; boundary=e89a8f647841bc97bb04f0fb44dd X-Virus-Checked: Checked by ClamAV on apache.org --e89a8f647841bc97bb04f0fb44dd Content-Type: text/plain; charset=ISO-8859-1 On Mon, Jan 27, 2014 at 1:41 PM, Alex Harui wrote: > This question is probably best answered by Om, but I think it would be > better to replace RuntimeLocale.as with a simple but extensible properties > files that get loaded as needed based on the locale. That way, new > locales can be added without re-compiling the installer. Is there some > aspect of RuntimeLocale that will be hard to replace? > > My plan would be to: > > 1) convert RuntimeLocale.as to a set of Ant-compatible .properties files > (id=string). > 2) the installer would load the selected locale's .properties files and > the en_US.properties from our website like we currently load > sdk-installer-config.xml > > Thoughts? > -Alex > > This is what we had in the very first iteration. But someone later (Erik, perhaps?) added the RuntimeLocale.as file. I am fine with either approach. Although, it would be nice to have an .as file with constants that look up the .property file entries instead of spreading them around in code. That would help with code completion. Also keep in mind that the flex-utilities/installerLocaleEditor app (built by Roland Zwaga) that is used to create new locales for the Installer kind of expects a certain class structure. Again, it would be nice if we make sure that we can continue to use this tool. Thanks, Om --e89a8f647841bc97bb04f0fb44dd--