flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From OmPrakash Muppirala <bigosma...@gmail.com>
Subject Re: [FlexJS] BarChart component added - render issue
Date Fri, 31 Jan 2014 05:11:09 GMT
On Thu, Jan 30, 2014 at 8:30 PM, Alex Harui <aharui@adobe.com> wrote:

> Om, something is still not configured right.  BarChart.js should be coming
> from frameworks/js/FlexJS/libs.


I dont see the libs folder here:
https://git-wip-us.apache.org/repos/asf?p=flex-asjs.git;a=tree;f=frameworks/js/FlexJS;h=868b43d18106fcb21b8b598ae60b96ddaf447d67;hb=develop



> There is no createElement call in my copy.
>

That is correct.  I am planning on adding an override of createElement in
BarChart.js

Thanks,
Om


>
> -Alex
>
> On 1/30/14 8:18 PM, "OmPrakash Muppirala" <bigosmallm@gmail.com> wrote:
>
> >On Jan 30, 2014 5:36 PM, "OmPrakash Muppirala" <bigosmallm@gmail.com>
> >wrote:
> >>
> >> On Thu, Jan 30, 2014 at 1:43 PM, Peter Ent <pent@adobe.com> wrote:
> >>>
> >>> I've pushed changes that should have the BarChart example working for
> >both
> >>> AS and JS. There is an issue with the axis appearing below the chart
> >>>that
> >>> causes the chart area (the dataGroup) to be larger than the chart
> >>>space.
> >>> This is an issue with getting the HTML/CSS right and any help/advice or
> >>> changes are welcome.
> >>>
> >>
> >> I figured out a fix by modifying the css in BarChart.js from the
> >bin/js-debug.  But this class gets cross-compiled from BarChart.as.  How
> >would I BarChart's css styles from the AS code?
> >>
> >> My fix involves adding this to BarChart.js:
> >>
> >> /**
> >>  * @override
> >>  */
> >>
> >
> >It should rather be:
> >org.apache.flex.charts.BarChart.prototype.createElement
> >
> >org.apache.flex.core.ListBase.prototype.createElement = function() {
> >>   this.element = document.createElement('div');
> >>   this.element.style.overflow = 'visible';
> >>   this.positioner = this.element;
> >>
> >>   return this.element;
> >> };
> >>
> >> Is this possible?
> >>
> >>>
> >>> --peter
> >>>
> >>> On 1/30/14 1:43 PM, "Peter Ent" <pent@adobe.com> wrote:
> >>>
> >>> >I have the BarChart example working in both AS and JS. The AS worked
> >right
> >>> >away but I discovered an issue with sizing the NonVirtualDataGroup in
> >>> >JavaScript. Or rather, the lack of sizing it. I am tracking that down
> >now.
> >>> >There are places in FlexJS where I don't have the size calculation
> >>>quite
> >>> >right or the function to calculate sizes isn't being called at the
> >>>right
> >>> >time, so I have some work to do on smoothing that out and making it
> >>> >consistent.
> >>> >
> >>> >I want to get the dataGroup size calculation in the right place for
> >>>the
> >>> >charts and then I'll check in the changed files.
> >>> >
> >>> >--peter
> >>> >
> >>> >On 1/29/14 6:29 PM, "Alex Harui" <aharui@adobe.com> wrote:
> >>> >
> >>> >>OK, things appear to be compiling and running again on the AS side.
> > Make
> >>> >>sure the BarChartExample works and you think it should.
> >>> >>
> >>> >>Thanks
> >>> >>-Alex
> >>> >>
> >>> >>On 1/29/14 2:12 PM, "Alex Harui" <aharui@adobe.com> wrote:
> >>> >>
> >>> >>>It is stale because it was using the custom bar chart and not
the
> >>>one
> >I
> >>> >>>moved to FLexJSJX.  I have it updated locally but there is a
problem
> >now
> >>> >>>because we're trying to use the Ifactory code gen in the compiler
> >>>and
> >it
> >>> >>>isn't working right.
> >>> >>>
> >>> >>>-Alex
> >>> >>>
> >>> >>>On 1/29/14 1:49 PM, "Peter Ent" <pent@adobe.com> wrote:
> >>> >>>
> >>> >>>>I wonder why it is stale? I'll take a look as well since
it will
> >>>help
> >>> >>>>me
> >>> >>>>remember and help with any JS issues.
> >>> >>>>
> >>> >>>>-peter
> >>> >>>>
> >>> >>>>On 1/29/14 4:07 PM, "Alex Harui" <aharui@adobe.com>
wrote:
> >>> >>>>
> >>> >>>>>I just discovered that the BarChartExample is stale.
 It isn't
> >>>using
> >>> >>>>>the
> >>> >>>>>BarChart now checked into FlexJSJX.  I'm going to try
to get it to
> >>> >>>>>compile
> >>> >>>>>and run in AS and then maybe Peter will have time to
look at the
> >>>JS
> >>> >>>>>side.
> >>> >>>>>
> >>> >>>>>-Alex
> >>> >>>>>
> >>> >>>>>On 1/29/14 11:59 AM, "Peter Ent" <pent@adobe.com>
wrote:
> >>> >>>>>
> >>> >>>>>>Please feel free to make adjustments. I have to
admit that the
> >>> >>>>>>particulars
> >>> >>>>>>of CSS escape me sometimes.
> >>> >>>>>>
> >>> >>>>>>Thanks for your help and checking this out.
> >>> >>>>>>
> >>> >>>>>>Peter
> >>> >>>>>>
> >>> >>>>>>On 1/29/14 2:40 PM, "OmPrakash Muppirala" <bigosmallm@gmail.com>
> >>> >>>>>>wrote:
> >>> >>>>>>
> >>> >>>>>>>When I compile and run the BarChartExample,
in the JS version,
> >this
> >>> >>>>>>>is
> >>> >>>>>>>what
> >>> >>>>>>>I am seeing (swf works fine)
> >>> >>>>>>>
> >>> >>>>>>>http://jsfiddle.net/cvLqE/
> >>> >>>>>>>
> >>> >>>>>>>Once I tweak the output html like this
> >>> >>>>>>>
> >>> >>>>>>>http://jsfiddle.net/52uaL/2/
> >>> >>>>>>>
> >>> >>>>>>>i.e. remove the position: absolute style attribute
of 'barChart'
> >>> >>>>>>>div,
> >>> >>>>>>>the
> >>> >>>>>>>bars show up, but are off a bit to the left
and top.
> >>> >>>>>>>
> >>> >>>>>>>Before I continue to investigate this, Peter,
is this a known
> >issue
> >>> >>>>>>>that
> >>> >>>>>>>you are planning on fixing?  I am seeing this
issue on both
> >Firefox
> >>> >>>>>>>and
> >>> >>>>>>>Chrome on Windows.
> >>> >>>>>>>
> >>> >>>>>>>Thanks,
> >>> >>>>>>>Om
> >>> >>>>>>>
> >>> >>>>>>>
> >>> >>>>>>>On Tue, Dec 17, 2013 at 12:49 PM, Peter Ent
<pent@adobe.com>
> >wrote:
> >>> >>>>>>>
> >>> >>>>>>>> Hi,
> >>> >>>>>>>>
> >>> >>>>>>>> I've added a simple BarChart component
to the ActionScript
> >FlexJS
> >>> >>>>>>>>SDK;
> >>> >>>>>>>>it
> >>> >>>>>>>> is modeled on the MX Charts package. I
also included an
> >>>example
> >of
> >>> >>>>>>>>using
> >>> >>>>>>>> it, located in the FlexJS examples directory.
> >>> >>>>>>>>
> >>> >>>>>>>> I developed the BarChart in ActionScript
but it can be
> >>> >>>>>>>>cross-compiled
> >>> >>>>>>>>into
> >>> >>>>>>>> JavaScript and produces the same chart.
The BarChartExample
> >>>has
> >>> >>>>>>>>the
> >>> >>>>>>>>sources
> >>> >>>>>>>> in the project so that you can compile
it for either
> >ActionScript
> >>> >>>>>>>>or
> >>> >>>>>>>> JavaScript.  I've included a README  in
that project with more
> >>> >>>>>>>>information.
> >>> >>>>>>>>
> >>> >>>>>>>> The intent, as with the DataGrid, is to
develop more complex
> >>> >>>>>>>>components
> >>> >>>>>>>>in
> >>> >>>>>>>> ActionScript and cross-compile them into
JavaScript, saving a
> >lot
> >>> >>>>>>>>of
> >>> >>>>>>>>time.
> >>> >>>>>>>> While doing this project I had to hand-craft
a JavaScript
> >>> >>>>>>>>component
> >>> >>>>>>>>to
> >>> >>>>>>>> display the bars since the ActionScript
version relies on the
> >>> >>>>>>>>Flash
> >>> >>>>>>>> Player's Shape class and that is not available
in HTML. I
> >>>think
> >>> >>>>>>>>this
> >>> >>>>>>>>really
> >>> >>>>>>>> illustrates the potential of FlexJS where
you can have a good
> >set
> >>> >>>>>>>>of
> >>> >>>>>>>> fundamental components that are environment
specific (e.g.,
> >>> >>>>>>>>Button,
> >>> >>>>>>>>Label,
> >>> >>>>>>>> and TextInput) which must be crafted for
all environments, but
> >>> >>>>>>>>complex
> >>> >>>>>>>> components can be written in ActionScript
and just
> >cross-compiled
> >>> >>>>>>>>into
> >>> >>>>>>>> JavaScript.
> >>> >>>>>>>>
> >>> >>>>>>>> My next task is add some simple axis labeling.
> >>> >>>>>>>>
> >>> >>>>>>>> Regards,
> >>> >>>>>>>> Peter Ent
> >>> >>>>>>>> Adobe Systems
> >>> >>>>>>>>
> >>> >>>>>>
> >>> >>>>>
> >>> >>>>
> >>> >>>
> >>> >>
> >>> >
> >>>
> >>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message