Mailing-List: contact dev-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flex.apache.org
Received-SPF: pass (athena.apache.org: domain of pent@adobe.com designates
 64.18.1.236 as permitted sender)
From: Peter Ent <pent@adobe.com>
To: "dev@flex.apache.org" <dev@flex.apache.org>
Date: Wed, 6 Nov 2013 08:13:05 -0800
Subject: Re: [FLEXJS] JS framework: gjslint
Thread-Topic: [FLEXJS] JS framework: gjslint
Thread-Index: Ac7bCxO6KZLsBg6iSimgL8hHn4W53A==
Message-ID: <CE9FD3D6.1C359%pent@adobe.com>
In-Reply-To: 
 <CAJs+wW0EuvS2RLOuG7USSvzpOUCGEqa-y9Ecd6y67eexL=cfHg@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.3.8.130913
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

I haven't tried all of the example yet. Was going to do that once I
finished up a wiki page and cleaned up the remaining glint issues.

The discrepancy is known and it is something I have been working on
recently. I haven't attempted any @interface stuff yet, so I created some
base classes to mimic interfaces (e.g., org.apache.flex.core.IBeadView)
but did not create one for org.apache.flex.core.IBead.

--peter

On 11/6/13 10:54 AM, "Erik de Bruin" <erik@ixsoftware.nl> wrote:

>I have spend the day running all JS files through JSHint and gjslint.
>I fixed about 6 errors that emerged (vars not declared etc.) up, but I
>also corrected all whitespace. It's a monster commit, if I get it
>finished ;-)
>
>Another issue: there is a rather large discrepancy between the class
>structure on the AS side vs. the JS side. Case in point is the lack of
>an IBeads interface on the JS side. I think the idea is to make the JS
>side mirror the structure of the AS side as closely as possible?
>
>And lastly (yeah, right... ;-)) how about the examples? Which ones are
>working for you, either in debug mode or in both debug AND release
>mode?
>
>EdB
>
>
>
>
>
>On Wed, Nov 6, 2013 at 4:48 PM, Peter Ent <pent@adobe.com> wrote:
>> I checked a number of files in yesterday and I'm pretty sure a handful
>> won't pass glint right now; I meant to do them all, but forgot some so
>>I'm
>> doing them this morning. If you want to go ahead and run the tool just
>>to
>> see if and how failures pop-up, go right ahead.
>>
>> --peter
>>
>> On 11/6/13 2:40 AM, "Erik de Bruin" <erik@ixsoftware.nl> wrote:
>>
>>>Hi,
>>>
>>>I would like to run the entire JS framework through the 'gjslint'
>>>tool. This is the JS linter provided by Google to check code that is
>>>to be processed by the Closure Compiler.
>>>
>>>It has some very strict whitespace rules, that will result in changes
>>>in most files (although we started out with a clean, gjslint approved
>>>version a long while ago, when I implemented 'goog' event handling).
>>>
>>>The main advantages are that all code will be consistently formatted
>>>and that it will most likely catch some annotation and related
>>>errors/omissions.
>>>
>>>If no one (Alex, Peter) has commits pending, I am ready to go.
>>>
>>>EdB
>>>
>>>
>>>
>>>--
>>>Ix Multimedia Software
>>>
>>>Jan Luykenstraat 27
>>>3521 VB Utrecht
>>>
>>>T. 06-51952295
>>>I. www.ixsoftware.nl
>>
>
>
>
>--=20
>Ix Multimedia Software
>
>Jan Luykenstraat 27
>3521 VB Utrecht
>
>T. 06-51952295
>I. www.ixsoftware.nl