flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject Re: git commit: [flex-sdk] [refs/heads/develop] - FIXED broken mustella tests after : FIXED mispelled variable that caused getter to be used instead.
Date Sun, 17 Nov 2013 15:51:14 GMT
Looks like there is a second test failing that might have been masked by
the first one.  Can you look at the latest run's failure?

Thanks,

-Alex

On 11/16/13 12:09 PM, "mamsellem@apache.org" <mamsellem@apache.org> wrote:

>Updated Branches:
>  refs/heads/develop fa12f02de -> 78eab008d
>
>
>FIXED broken mustella tests after :  FIXED mispelled variable that caused
>getter to be used instead.
>
>
>Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
>Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/78eab008
>Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/78eab008
>Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/78eab008
>
>Branch: refs/heads/develop
>Commit: 78eab008df51bf8cd2bb7313d5a0a1222627cd5e
>Parents: fa12f02
>Author: mamsellem <maurice.amsellem@systar.com>
>Authored: Sat Nov 16 21:09:36 2013 +0100
>Committer: mamsellem <maurice.amsellem@systar.com>
>Committed: Sat Nov 16 21:09:36 2013 +0100
>
>----------------------------------------------------------------------
> frameworks/projects/spark/src/spark/components/Grid.as | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>----------------------------------------------------------------------
>
>
>http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/78eab008/frameworks/p
>rojects/spark/src/spark/components/Grid.as
>----------------------------------------------------------------------
>diff --git a/frameworks/projects/spark/src/spark/components/Grid.as
>b/frameworks/projects/spark/src/spark/components/Grid.as
>index 4a0be60..59aefac 100644
>--- a/frameworks/projects/spark/src/spark/components/Grid.as
>+++ b/frameworks/projects/spark/src/spark/components/Grid.as
>@@ -5596,15 +5596,16 @@ public class Grid extends Group implements
>IDataGridElement, IDataProviderEnhanc
>     private function
>dataProvider_collectionChangeHandler(event:CollectionEvent):void
>     {
>         var selectionChanged:Boolean = false;
>-        
>+
>+
>         // If no columns exist, we should try to generate them.
>         if (!columns && dataProvider.length > 0)
>         {
>             columns = generateColumns();
>             generatedColumns = (columns != null);
>-            gridDimensions.columnCount = generatedColumns ?
>columns.length : 0;
>+            this.gridDimensions.columnCount = generatedColumns ?
>columns.length : 0;
>         }
>-        
>+
>         const gridDimensions:GridDimensions = this.gridDimensions;
>         if (gridDimensions)
>         {
>


Mime
View raw message