Mailing-List: contact dev-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flex.apache.org
Received-SPF: pass (nike.apache.org: domain of aharui@adobe.com designates
 64.18.1.234 as permitted sender)
From: Alex Harui <aharui@adobe.com>
To: "dev@flex.apache.org" <dev@flex.apache.org>
Date: Wed, 9 Oct 2013 22:52:38 -0700
Subject: RE: Build failed in Jenkins: flex-sdk_mustella #460
Thread-Topic: Build failed in Jenkins: flex-sdk_mustella #460
Thread-Index: Ac7FeJ8tXdEQ1bUVQ3W5R1jhK/fErwABE398
Message-ID: 
 <F85F710414401743B5093C1CCDD0F3AD944AB37829@NAMBX02.corp.adobe.com>
References: <26760942.10.1381293756614.JavaMail.FLEX-MUSTELLA$@flex-mustella>
 <F85F710414401743B5093C1CCDD0F3AD944AB37826@NAMBX02.corp.adobe.com>,<5DDAB2E6-9872-494B-A949-751584860B4D@apache.org>
 <F85F710414401743B5093C1CCDD0F3AD944AB37827@NAMBX02.corp.adobe.com>,<B40AF7E7-77EE-4240-B343-929377048768@apache.org>
In-Reply-To: <B40AF7E7-77EE-4240-B343-929377048768@apache.org>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

When I look at the diffs, I don't see the clearFlag line until Nick adds it=
.  The comment above the "if (!stylesheet)" makes me think the flag shouldn=
't be cleared, but I haven't really looked into it.

I also took out the clearFlag call and the tests passed. =20

Right now, I'm more puzzled why Nick's revert isn't showing up.

-Alex
________________________________________
From: Justin Mclean [jmclean@apache.org]
Sent: Wednesday, October 09, 2013 10:21 PM
To: dev@flex.apache.org
Subject: Re: Build failed in Jenkins: flex-sdk_mustella #460

Hi,

> What do you see that's wrong with the tests?
If you look at the fix:

From:

if (!styleSheet)
        htmlText =3D null;
        textfield.clearFlag(FTETextField.FLAG_HTML_TEXT_SET);

To:

        if (!styleSheet)
        {
                htmlText =3D null;
                textfield.clearFlag(FTETextField.FLAG_HTML_TEXT_SET);
        }

Giving that the tests basically do the same thing, except that autoSize is =
set to different values (auto or left). It not that unreasonable that corre=
ctly clearing the HTML set flag could result in different results in the wi=
dth calculation (given it's formatted HTML text). The test currently assume=
 the width is the same in each case.

> Nick's revert of his change and "git log" doesn't show it either
I'm not seeing the revert either - perhaps a merge issue?

Thanks,
Justin