Mailing-List: contact dev-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flex.apache.org
Received-SPF: pass (nike.apache.org: domain of aharui@adobe.com designates
 64.18.1.233 as permitted sender)
From: Alex Harui <aharui@adobe.com>
To: "dev@flex.apache.org" <dev@flex.apache.org>
Date: Tue, 15 Oct 2013 10:09:48 -0700
Subject: Re: Build failed in Jenkins: flex-sdk_mustella #470
Thread-Topic: Build failed in Jenkins: flex-sdk_mustella #470
Thread-Index: Ac7JyVy+GfyXxB6vTR+VIx1fnDk7Sg==
Message-ID: <CE82C376.F162%aharui@adobe.com>
In-Reply-To: 
 <2095F5EBE04D59409DFCE91FFCEBF7AF3F535BDC@EXMBX05.netplexity.local>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.3.6.130613
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0


On 10/15/13 9:52 AM, "Maurice Amsellem" <maurice.amsellem@systar.com>
wrote:

>>I will try to generate and check in png.xml files for the two failing
>>tests
>
>Not sure to understand what png.xml files are ? the baseline pngs ?
A png.xml file is an XML description of the display list.  We use them
when different player versions or mac-vs-win give slightly different
bitmaps.  There are only a few checked in right now.  CompareBitmap first
compares the .png file  and then if it fails it looks for the png.xml and
compares the display list.  The theory is that Flex code really only
manipulates display list properties so if a component is at x=3D4.5 we don'=
t
truly care what pixel colors the player chooses for pixel 4 and 5, we just
want our code to set that component at x=3D4.5.

Now if the test still fails you can compare the png.xml output and see
where the proposed code did change some display list property.  So far,
that's found a few subtle bugs in our code.

I'm still trying to get the repo back to where those tests pass so I can
generate the right png.xml files, so I'm not ready to check them in just
yet.

-Alex