Mailing-List: contact dev-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flex.apache.org
Received-SPF: pass (athena.apache.org: domain of aharui@adobe.com designates
 64.18.1.189 as permitted sender)
From: Alex Harui <aharui@adobe.com>
To: Maurice Amsellem <maurice.amsellem@systar.com>,
        "dev@flex.apache.org"
	<dev@flex.apache.org>
Date: Thu, 10 Oct 2013 07:56:03 -0700
Subject: Re: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)
Thread-Topic: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)
Thread-Index: Ac7FyNnwrhJJhOc7SoSm7aHIo2afKw==
Message-ID: <CE7C0CBC.1E632%aharui@adobe.com>
In-Reply-To: 
 <2095F5EBE04D59409DFCE91FFCEBF7AF3F53264D@EXMBX05.netplexity.local>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.3.6.130613
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0


On 10/9/13 11:51 PM, "Maurice Amsellem" <maurice.amsellem@systar.com>
wrote:

>Understood.
>
>In this case, I' am changing the test code so that it matches the
>existing baseline, not changing the baseline.
>So it should not have any impact.
Maybe I'm not understanding you, but IMO, the test code represents a
user's application.  Every time you change the test code, it means that
some number of our customers will also have to change their application
code.  For sure, sometimes that number is 0 because the test is
incorrectly written, and sometimes the number is small and we decide the
fix is more important (and in the case of a security issue, it doesn't
matter how many people it breaks).

If I understand this thread, some number of folks with custom skins may
have to tweak their skins, otherwise they may notice a one pixel shift in
the callout position.  Again, I'm not saying don't do that, but consider
whether that is an acceptable result.  You may have the option of using a
version flag to allow folks to get back to old behavior.

-Alex