Mailing-List: contact dev-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flex.apache.org
Received-SPF: pass (athena.apache.org: domain of maurice.amsellem@systar.com
 designates 66.129.85.153 as permitted sender)
From: Maurice Amsellem <maurice.amsellem@systar.com>
To: "dev@flex.apache.org" <dev@flex.apache.org>
Subject: RE: describeType still used in many places in SDK
Thread-Topic: describeType still used in many places in SDK
Thread-Index: 
 Ac7Fw6Mdp3Rv3fP3RKGxYqxIWoM9AwALuguAAAg5nVD//8YYgIAAQuNQ///IXYCAAAMigIAAOxOg///OsoCAADfRMIAAblJwgADateA=
Date: Thu, 10 Oct 2013 18:44:04 +0000
Message-ID: 
 <2095F5EBE04D59409DFCE91FFCEBF7AF3F532DAE@EXMBX05.netplexity.local>
References: 
 <2095F5EBE04D59409DFCE91FFCEBF7AF3F532D31@EXMBX05.netplexity.local>
 <CE7C3691.1E6C0%aharui@adobe.com>
 <2095F5EBE04D59409DFCE91FFCEBF7AF3F532D78@EXMBX05.netplexity.local>
 <2095F5EBE04D59409DFCE91FFCEBF7AF3F532D92@EXMBX05.netplexity.local>
In-Reply-To: 
 <2095F5EBE04D59409DFCE91FFCEBF7AF3F532D92@EXMBX05.netplexity.local>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

describeTypeJSON has access control flags:
INCLUDE_BASES | INCLUDE_INTERFACES | INCLUDE_VARIABLES | INCLUDE_ACCESSORS =
| INCLUDE_METHODS | INCLUDE_METADATA | INCLUDE_CONSTRUCTOR | INCLUDE_TRAITS=
 | HIDE_OBJECT| USE_ITRAITS;

For the tests, I have using all the flags, to be equivalent with former des=
cribeType.

So it could be even better if you only need some of the reflection info...

Maurice=20

-----Message d'origine-----
De=A0: Maurice Amsellem [mailto:maurice.amsellem@systar.com]=20
Envoy=E9=A0: jeudi 10 octobre 2013 20:37
=C0=A0: dev@flex.apache.org
Objet=A0: RE: describeType still used in many places in SDK

(EDITED: added new lines):

I just did some benchmarks on UI and non UI classes (run several times each=
 test, the results are consistent) :


[trace] [Chrono: [class Button] descripeType x1000] duration=3D 11.123 s=20

[trace] [Chrono: [class Label] descripeType x1000] duration=3D 12.064 s=20

[trace] [Chrono: [class EntityMosaic] descripeType x1000] duration=3D 1.776=
 s=20

[trace] [Chrono: [class ApplicationViewBase_P] descripeType x1000] duration=
=3D 13.977 s

_________

[trace] [Chrono: [class Button] descripeTypeJSON x1000] duration=3D 3.449 s=
=20

[trace] [Chrono: [class Label] descripeTypeJSON x1000] duration=3D 3.686 s=
=20

[trace] [Chrono: [class EntityMosaic] descripeTypeJSON x1000] duration=3D 0=
.486 s=20

[trace] [Chrono: [class ApplicationViewBase_P] descripeTypeJSON x1000] dura=
tion=3D 4.033 s

So descripeTypeJSON is roughly 3.5 time faster.

I think the optimization is worth it, especially on UI classes reflection.=
=20
WDYT?

Maurice

-----Message d'origine-----
De=A0: Alex Harui [mailto:aharui@adobe.com] Envoy=E9=A0: jeudi 10 octobre 2=
013 19:49 =C0=A0: dev@flex.apache.org Objet=A0: Re: describeType still used=
 in many places in SDK

I wouldn't bother.

On 10/10/13 10:44 AM, "Maurice Amsellem" <maurice.amsellem@systar.com>
wrote:

>That may sound like a dumb question, but since Apache Flex only=20
>supports FP 10.2 and beyond, do we even need to make the check for 10.1 ?
>
>Maurice
>
>-----Message d'origine-----
>De : Michael A. Labriola [mailto:labriola@digitalprimates.net]
>Envoy=E9 : jeudi 10 octobre 2013 19:14
>=C0 : dev@flex.apache.org
>Objet : RE: describeType still used in many places in SDK
>
>>Before we switch to it, we have to be absolutely sure of when it was=20
>>first supported.  I wouldn't want to break our Flash version=20
>>compatibility range.  But otherwise, I have no objections if you want=20
>>to switch to it.
>
>If it helps, in my code, I am checking for FP10.1 or higher which is=20
>when I switch to describeTypeJSON instead of the original. It's in=20
>avmplus
>
>There is a bug filed for Tamarin in BugZilla to have in documented as=20
>of 3/21/2011. [1]
>
>Mike
>
>[1] https://bugzilla.mozilla.org/show_bug.cgi?id=3D643455