flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject RE: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)
Date Thu, 10 Oct 2013 00:42:30 GMT
When you change a test please consider impact on folks who might have pixel tuned their app
and may notice the difference. I'm not saying don't change, but be careful.

Sent via the PANTECH Discover, an AT&T 4G LTE smartphone.

Maurice Amsellem <maurice.amsellem@systar.com> wrote:

No, because the test on line 579 is:
var showBorder:Boolean = !isNaN(borderThickness);

In the desktop skin, I am setting  it that way:
var showBorder:Boolean = !isNaN(borderThickness) || borderThickness > 0 ;

Should I change the test ?


-----Message d'origine-----
De : Justin Mclean [mailto:justin@classsoftware.com]
Envoyé : jeudi 10 octobre 2013 01:23
À : dev@flex.apache.org
Objet : Re: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)


> So the variable showBorder on line 579 is set to true.
If borderThinkness is 0 shouldn't showBorder be false? Then the callout should be in the right


View raw message