flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject RE: Build failed in Jenkins: flex-sdk_mustella #460
Date Thu, 10 Oct 2013 05:52:38 GMT
When I look at the diffs, I don't see the clearFlag line until Nick adds it.  The comment above
the "if (!stylesheet)" makes me think the flag shouldn't be cleared, but I haven't really
looked into it.

I also took out the clearFlag call and the tests passed.  

Right now, I'm more puzzled why Nick's revert isn't showing up.

-Alex
________________________________________
From: Justin Mclean [jmclean@apache.org]
Sent: Wednesday, October 09, 2013 10:21 PM
To: dev@flex.apache.org
Subject: Re: Build failed in Jenkins: flex-sdk_mustella #460

Hi,

> What do you see that's wrong with the tests?
If you look at the fix:

From:

if (!styleSheet)
        htmlText = null;
        textfield.clearFlag(FTETextField.FLAG_HTML_TEXT_SET);

To:

        if (!styleSheet)
        {
                htmlText = null;
                textfield.clearFlag(FTETextField.FLAG_HTML_TEXT_SET);
        }

Giving that the tests basically do the same thing, except that autoSize is set to different
values (auto or left). It not that unreasonable that correctly clearing the HTML set flag
could result in different results in the width calculation (given it's formatted HTML text).
The test currently assume the width is the same in each case.

> Nick's revert of his change and "git log" doesn't show it either
I'm not seeing the revert either - perhaps a merge issue?

Thanks,
Justin

Mime
View raw message