flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject Re: [Mustella] tests/experimental/spark/components/CallOutButton
Date Wed, 16 Oct 2013 16:25:26 GMT
It is always a concern to remove a feature, but CallOutButton was
experimental so there is less guarantee of APIs.

IMO, you can leave it as is and we'll see if folks complain.

-Alex

On 10/16/13 9:19 AM, "Maurice Amsellem" <maurice.amsellem@systar.com>
wrote:

>I didn't know about this MetaData.
>The original CalloutButton does not have it: by default, you must click
>to make the callout appear.
>
>You can simulate this behavior with this trick:
>
><s:CalloutButton id="calloutButtonBasic" label="button"
>horizontalCenter="0" verticalCenter="0"
>     rollOver="calloutButtonBasic.openDropDown()"
>   rollOut="calloutButtonBasic.closeDropDown()"  >
>
>WDYT? 
>
>Maurice 
>
>-----Message d'origine-----
>De : Alex Harui [mailto:aharui@adobe.com]
>Envoyé : mercredi 16 octobre 2013 18:13
>À : dev@flex.apache.org
>Objet : Re: [Mustella] tests/experimental/spark/components/CallOutButton
>
>It appears that CallOutButton had a "triggerEvent" in its metadata so the
>MXML could look like <ns:CallOutButton triggerEvent="rollOver" />
>
>On 10/16/13 8:57 AM, "Maurice Amsellem" <maurice.amsellem@systar.com>
>wrote:
>
>>Do you mean, the "rollover" event that is in CallouButton_Basic.mxml
>>test cases, does not trigger for CalloutButton ?
>>
>>
>>
>>-----Message d'origine-----
>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : mercredi 16 octobre
>>2013 17:34 À : dev@flex.apache.org Objet : Re: [Mustella]
>>tests/experimental/spark/components/CallOutButton
>>
>>I tried fixing those tests, but they seem to use a triggerEvent which I
>>didn't see on CalloutButton.  Do you know what the equivalent would be?
>>
>>-Alex
>>
>>On 10/16/13 8:01 AM, "Maurice Amsellem" <maurice.amsellem@systar.com>
>>wrote:
>>
>>>There are tests on CalloutButton, and "indirect" tests of Callout in
>>>SplitViewNavigator, but they are all in the mobile area.
>>>
>>>I think we should create Callout / CalloutButton tests in the
>>>gumbo/components directory as well, and remove the experimental tests.
>>>
>>>Or maybe just move the experimental tests into gumbo, renaming
>>>CallOutButton to CalloutButton and recreating the baseline pngs.
>>>
>>>WDYT?
>>>
>>>Maurice
>>>
>>>-----Message d'origine-----
>>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : mercredi 16 octobre
>>>2013 16:55 À : dev@flex.apache.org Objet : Re: [Mustella]
>>>tests/experimental/spark/components/CallOutButton
>>>
>>>Are there tests for Callout and CalloutButton already?  If so, then
>>>these experimental tests can be removed.
>>>
>>>-Alex
>>>
>>>On 10/16/13 7:48 AM, "Maurice Amsellem" <maurice.amsellem@systar.com>
>>>wrote:
>>>
>>>>CallOutButton and CallOut classes do not exist anymore.
>>>>They have been merged with Callout and CalloutButton, using spark
>>>>skins.
>>>>
>>>>So IMO, the tests should be removed, or at least replaced by tests on
>>>>Callout / CalloutButton using the spark skins instead of the mobile
>>>>skins.
>>>>
>>>>WDYT?
>>>>
>>>>Maurice
>>>>
>>>>-----Message d'origine-----
>>>>De : Alex Harui [mailto:aharui@adobe.com] Envoyé : mercredi 16
>>>>octobre
>>>>2013 16:43 À : dev@flex.apache.org Objet : [Mustella]
>>>>tests/experimental/spark/components/CallOutButton
>>>>
>>>>These tests do not compile for me.  Do they work for anyone else?
>>>>
>>>>I can't find where they are excluded.
>>>>
>>>>-Alex
>>>>
>>>
>>
>


Mime
View raw message